-
Notifications
You must be signed in to change notification settings - Fork 1.1k
patch: add setUsingInternalLocationService method #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
============================================
+ Coverage 84.12% 84.13% +0.01%
- Complexity 1018 1019 +1
============================================
Files 84 84
Lines 2941 2943 +2
Branches 303 303
============================================
+ Hits 2474 2476 +2
Misses 432 432
Partials 35 35
Continue to review full report at Codecov.
|
@@ -167,4 +167,10 @@ public boolean isUsingVpcEndpoint() { | |||
public void enableUsingVpcEndpoint() { | |||
this.usingVpcEndpoint = true; | |||
} | |||
|
|||
@Override | |||
@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
写上用什么替代。
aliyun-java-sdk-core/pom.xml
Outdated
@@ -4,7 +4,7 @@ | |||
<groupId>com.aliyun</groupId> | |||
<artifactId>aliyun-java-sdk-core</artifactId> | |||
<packaging>jar</packaging> | |||
<version>4.3.1</version> | |||
<version>4.3.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
发版 单独 PR。
@Override | ||
@Deprecated | ||
public void setUsingInternalLocationService() { | ||
usingInternalLocationService = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
实现上你应该去调用 enableXXX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
而不是重复的代码写一遍。
No description provided.