Skip to content

patch: add setUsingInternalLocationService method #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2019
Merged

patch: add setUsingInternalLocationService method #120

merged 2 commits into from
Jan 16, 2019

Conversation

atptro
Copy link
Contributor

@atptro atptro commented Jan 16, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #120 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #120      +/-   ##
============================================
+ Coverage     84.12%   84.13%   +0.01%     
- Complexity     1018     1019       +1     
============================================
  Files            84       84              
  Lines          2941     2943       +2     
  Branches        303      303              
============================================
+ Hits           2474     2476       +2     
  Misses          432      432              
  Partials         35       35
Impacted Files Coverage Δ Complexity Δ
...main/java/com/aliyuncs/profile/DefaultProfile.java 70% <100%> (+0.88%) 21 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53eaec7...a0f3c2f. Read the comment docs.

@@ -167,4 +167,10 @@ public boolean isUsingVpcEndpoint() {
public void enableUsingVpcEndpoint() {
this.usingVpcEndpoint = true;
}

@Override
@Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

写上用什么替代。

@@ -4,7 +4,7 @@
<groupId>com.aliyun</groupId>
<artifactId>aliyun-java-sdk-core</artifactId>
<packaging>jar</packaging>
<version>4.3.1</version>
<version>4.3.2</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发版 单独 PR。

@Override
@Deprecated
public void setUsingInternalLocationService() {
usingInternalLocationService = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实现上你应该去调用 enableXXX

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

而不是重复的代码写一遍。

@JacksonTian JacksonTian merged commit ec8bf08 into aliyun:master Jan 16, 2019
@atptro atptro deleted the patchAddSetMethod branch January 16, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants