-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Fix comments typo, rename param, refine obtainMessage #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
library/src/main/java/com/loopj/android/http/AssertUtils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
Android Asynchronous Http Client | ||
Copyright (c) 2011 James Smith <james@loopj.com> | ||
http://loopj.com | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package com.loopj.android.http; | ||
|
||
/** | ||
* Internal class, used to make some asserts, throw AssertError if asserts fail. | ||
*/ | ||
class AssertUtils { | ||
|
||
private AssertUtils() { | ||
} | ||
|
||
public static void asserts(final boolean expression, final String failedMessage) { | ||
if (!expression) { | ||
throw new AssertionError(failedMessage); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zxw1962
This is wrong as
handler
could be null. The alternative when that happens is meant to emulate aMessage.obtain()
, so the entire method has to stay as-is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zxw1962 yes, sincerely this is invalid change, we have to support different scenarios, and this is key component that was written like this for that purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fineswap @smarek why handler is null need to be handled differently? for me, Message.obtain() call is the same as Message.obtain(null, what, obj), isn't it? so, we don't have to test for null, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zxw1962
This is correct now, but what happens in the future if the underlying implementation changes and a check for null is introduced to
Message.obtain()
? (by the Android team, or any other manufacturer -- Nokia X, Sony, Samsund, htc, etc. -- who goes in and changes the source code to their satisfaction.)Potentially, this will make all apps relying on AHC to fail if the device is upgraded to run a newer Android (with a different implementation for Message.obtain()).
We have to consider that this library is used by thousands of apps and we have to rely on backward-compatibility even if leaving some useless (currently) code around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fineswap future changes to this API is unlikely, as this is stable behavior since API v1
@zxw1962 I'm sorry, I've gone too quickly through implementation of Message API, this is correct change, as the [
Message.obtain(Handler,int,Object)
](https://developer.android.com/reference/android/os/Message.html#obtain%28android.os.Handler, int, java.lang.Object%29) just sets passed values into internal fields of Message. I'm pulling back my previous complaints.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so what should I do, revert or just leave it as it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave it, I approve the change, it's correct, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks, will update others soon...