Update the sendResponseMessage with a protected modifier and fix a spelling error. #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 16, 2012 16:44
…classes can override the method's functionality.
…nseMessage method to match the change made to the parent class.
|
Support this pull, getting warning: |
|
I second the "situation where we need access to the raw HttpResponse object to get at the response headers and status code". It would be very nice if response headers and status code would be passed along in onSuccess and onFailure in any case. |
|
Is there another way to get the status codes (until this gets merged)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning on using this library for a larger project and may be submitting more patches in the future. Just wanted to get this small fix in and see how it goes.
I updated the sendResponseMessage with the protected modifier so subclasses could override it's functionality. Basically a few of us are running into a situation where we need access to the raw HttpResponse object to get at the response headers and status code. If we can override this method we can subclass AsyncHttpResponseHandler and get at those values.