Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5.2.7
Choose a base ref
...
head repository: angular/angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5.2.8
Choose a head ref
  • 18 commits
  • 43 files changed
  • 11 contributors

Commits on Feb 28, 2018

  1. build: update api golden files (#22402)

    `ts-api-guardion` has been updated to accept new TypeScript syntax
    
    PR Close #22402
    alan-agius4 authored and alexeagle committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    9137650 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    089769d View commit details
    Browse the repository at this point in the history
  3. docs: fix dynamic component loader example (#22181)

    	closes #21903
    
    PR Close #22181
    kapunahelewong authored and alexeagle committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    0ec11e3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1593bff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    697d31a View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. build(aio): initialise exampleMap correctly (#22502)

    The `exampleMap` needs to hold an hash object for each
    of the `collectExamples.exampleFolders` paths.
    
    Previously these hash objects were only created if there
    was actually an example file the hash's respective
    example folder.  This could cause crashes during
    `yarn docs-watch` (and so also `yarn sync-and-serve`)
    if no examples were read in for a particular run of
    the doc-gen.
    
    PR Close #22502
    petebacondarwin authored and alexeagle committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    f8e70fb View commit details
    Browse the repository at this point in the history
  2. build(aio): move link disambiguation from getLinkInfo to `getDocFro…

    …mAlias` (#22494)
    
    The disambiguation needs to be done earlier so that the auto-link-code
    post-processor can benefit from it.
    
    PR Close #22494
    petebacondarwin authored and alexeagle committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    855e3a6 View commit details
    Browse the repository at this point in the history
  3. build(aio): improve accuracy of code auto-linking (#22494)

    The new version of `dgeni-packages/typescript` no longer strips
    out "namespaces" from types, which was part of the problem of
    not autolinking correctly to `HttpEventType.Response`.
    
    Another part of the problem was that we did not include `.`
    characters when matching potential code blocks for auto-linking,
    which precluded properties of enums from being linked.
    
    Finally, members we not being given a `path` property, which is
    needed to effectively autolink to them. This is now set in
    the `simplifyMemberAnchors` processor.
    
    Closes #21375
    
    PR Close #22494
    petebacondarwin authored and alexeagle committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    27962f8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fe0d53f View commit details
    Browse the repository at this point in the history
  5. ci: speed up lint job on CircleCI (#22526)

    When I enabled bazel remote caching, I also switched to running
    buildifier and skylint from the package.json script, which builds them
    from head. With remote caching, we do get cache hits for these, but
    looking up the action inputs actually takes quite a bit of time since we
    have to first fetch the remote repository, then do loading and
    analysis, then read the inputs to determine the cache key.
    
    It's more important to keep the lint job fast, so I'm reverting that
    part of the change for now. We can experiment with building them from
    head in a less critical repo.
    
    PR Close #22526
    alexeagle committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    ff7e2e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Configuration menu
    Copy the full SHA
    a3f7e30 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. docs(aio): fix table header (#22553)

    PR Close #22553
    SangKa authored and alexeagle committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    984a13e View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. fix(router): fix URL serialization so special characters are only enc…

    …oded where needed (#22337)
    
    This change brings Angular largely in line with how AngularJS previously serialized URLs. This is based on RFC 3986 and resolves issues such as the above #10280 where URLs could be parsed, re-serialized, then parsed again producing a different result on the second parsing.
    
    Adjustments to be aware of in this commit:
    
    * URI fragments will now serialize the same as query strings
    * In the URI path or segments (portion prior to query string and/or fragment), the plus sign (`+`) and ampersand (`&`) will appear decoded
    * In the URL path or segments, parentheses values (`(` and `)`) will now appear percent encoded as `%28` and `%29` respectively
    * In the URL path or segments, semicolons will be encoded in their percent encoding `%3B`
    
    NOTE: Parentheses and semicolons denoting auxillary routes or matrix params will still appear in their decoded form -- only parentheses and semicolons used as values in a segment or key/value pair for matrix params will be encoded.
    
    While these changes are not considered breaking because applications should be decoding URLs and key/value pairs, it is possible that some unit tests will break if comparing hard-coded URLs in tests since that hard coded string will represent the old encoding. Therefore we are releasing this fix in the upcoming Angular v6 rather than adding it to a patch for v5.
    
    Fixes: #10280
    
    PR Close #22337
    jasonaden authored and alexeagle committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    789a47e View commit details
    Browse the repository at this point in the history
  2. docs: fix cli-quickstart doc and specs (#22338)

    * tests were broken
    * incorrect instructions.
    * didn't match current CLI template for new project
    
    PR Close #22338
    wardbell authored and alexeagle committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    5b7b208 View commit details
    Browse the repository at this point in the history
  3. docs(aio): update deprecated Http reference to HttpClientModule, remo…

    …ve Http reference because another context is used (#21984)
    
    docs(aio): change HttpClientModule reference to HttpClient
    
    docs(aio): capitalize Http to HTTP
    
    docs(aio): fix typo mistake in 'universal' guide
    
    docs(aio): gets rid of the parentheses and the "e.g." in 'universal' guide
    
    PR Close #21984
    Yerkon authored and alexeagle committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    5876fb0 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2018

  1. docs: update RELEASE_SCHEDULE.md by pushing out v6 rc by one week

    We are pushing RC and Final out by one week because of RxJS v6 complications that are blocking the release. No further delays are currently expected.
    IgorMinar authored and alexeagle committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    4aeb04d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bdee824 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a236b4 View commit details
    Browse the repository at this point in the history
Loading