What do you mean by "broken"? See #17158

Different symptom - Logs are showing "ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked." However, it is adblocker related. Disabling uBlock resolves this. This is an concern, since Angular is used to build many enterprise applications and many end users will have adblockers installed as a company infosec policy.

Should I just close this issue out since it seems related to the issue you linked?

@dankellett ... it is not related to any adblocker.

I see what you mean. The app runs with Adblocker disabled but it is still producing the console error with adblockers disabled. This suggests that these are likely two different issues.

So the symptom is solely that this functionality in the demo doesn't work when adblocker is running, which seems to be tracked in #17158.

@dankellett ... this is the only change that is enough to solve the problem in thit case ... ngOnInit() instead of ngAfterViewInit() is the most simple solution ... but be careful - not in every similar case ...

export class AdBannerComponent implements OnDestroy, OnInit {
   ...
   constructor(private componentFactoryResolver: ComponentFactoryResolver) { }

   ngOnInit() {
      this.loadComponent();
      this.getAds();
   }
   ...
}

For people coming from Google, https://blog.angularindepth.com/everything-you-need-to-know-about-the-expressionchangedafterithasbeencheckederror-error-e3fd9ce7dbb4 helped me understand what's going on. ngOnInit fixed it.

P.S.: while you're at it... currentAddIndex should become currentAdIndex (not just in the example code, also referenced in docs), app-add-banner should be appAdBanner and there appears to be an unused subscription field in AdBannerComponent that can be removed.

@dankellett, Can you try this solution: #22020?

Hey, thanks for finding this @dankellett. I learned something new! 👍

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}