-
Notifications
You must be signed in to change notification settings - Fork 26.2k
ci: use sudo: false
on Travis
#21641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7708f7e
to
e7d290b
Compare
You can preview a4e48a1 at https://pr21641-a4e48a1.ngbuilds.io/. |
bfa9e03
to
f752c6e
Compare
You can preview f752c6e at https://pr21641-f752c6e.ngbuilds.io/. |
f752c6e
to
dc2ea1e
Compare
You can preview dc2ea1e at https://pr21641-dc2ea1e.ngbuilds.io/. |
Related to angular#21422.
dc2ea1e
to
f35d7d5
Compare
You can preview f35d7d5 at https://pr21641-f35d7d5.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
In order to align with the `angular/angular` setup, we also remove the temporary Chrome Headless Sandbox workaround in favor of faster Travis CI containers. To be able to still use headless chrome, we specify the `no-sandbox` flag. Reference angular/angular#21641
In order to align with the `angular/angular` setup, we also remove the temporary Chrome Headless Sandbox workaround in favor of faster Travis CI containers. To be able to still use headless chrome, we specify the `no-sandbox` flag. Reference angular/angular#21641
Related to angular#21422. PR Close angular#21641
Related to angular#21422. PR Close angular#21641
Related to angular#21422. PR Close angular#21641
Related to angular#21422. PR Close angular#21641
Related to angular#21422. PR Close angular#21641
Related to angular#21422. PR Close angular#21641
This fix is based on the suggestions from travis-ci/travis-ci#9024 (comment) and travis-ci/travis-ci#8836 (comment). If using `sudo: false` is undesirable, it appears that there is another potential solution: angular/angular#21641
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
sude: required
: Travis jobs run on non-container-based infrastructure (on VMs from the open source pool).What is the new behavior?
sudo: false
: Travis jobs run on the container-based infrastructure (on VMs from our pre-paid pool).Does this PR introduce a breaking change?
Other information
In order to switch back to
sude: false
(and take advantage of our paid poolof VMs), we need to run Chrome/Chromium with the--no-sandbox
flag.Related to #21422.
Relevant discussion: travis-ci/travis-ci#8836