Skip to content

ci: use sudo: false on Travis #21641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jan 18, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

[x] CI related changes

What is the current behavior?

sude: required: Travis jobs run on non-container-based infrastructure (on VMs from the open source pool).

What is the new behavior?

sudo: false: Travis jobs run on the container-based infrastructure (on VMs from our pre-paid pool).

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

In order to switch back to sude: false (and take advantage of our paid poolof VMs), we need to run Chrome/Chromium with the --no-sandbox flag.
Related to #21422.

Relevant discussion: travis-ci/travis-ci#8836

@gkalpak gkalpak added state: WIP area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Jan 18, 2018
@mary-poppins
Copy link

You can preview a4e48a1 at https://pr21641-a4e48a1.ngbuilds.io/.

@gkalpak gkalpak force-pushed the ci-sudo-false branch 2 times, most recently from bfa9e03 to f752c6e Compare January 19, 2018 09:38
@mary-poppins
Copy link

You can preview f752c6e at https://pr21641-f752c6e.ngbuilds.io/.

@mary-poppins
Copy link

You can preview dc2ea1e at https://pr21641-dc2ea1e.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f35d7d5 at https://pr21641-f35d7d5.ngbuilds.io/.

@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Jan 19, 2018
@gkalpak gkalpak requested a review from IgorMinar January 19, 2018 11:44
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 19, 2018
@mhevery mhevery closed this in 8e8924a Jan 19, 2018
devversion added a commit to devversion/material2 that referenced this pull request Jan 20, 2018
In order to align with the `angular/angular` setup, we also remove the temporary Chrome Headless Sandbox workaround in favor of faster Travis CI containers. To be able to still use headless chrome, we specify the `no-sandbox` flag.

Reference angular/angular#21641
@gkalpak gkalpak deleted the ci-sudo-false branch January 20, 2018 15:13
jelbourn pushed a commit to angular/components that referenced this pull request Jan 22, 2018
In order to align with the `angular/angular` setup, we also remove the temporary Chrome Headless Sandbox workaround in favor of faster Travis CI containers. To be able to still use headless chrome, we specify the `no-sandbox` flag.

Reference angular/angular#21641
mhevery pushed a commit to mhevery/angular that referenced this pull request Jan 25, 2018
gkalpak added a commit to petebacondarwin/angular that referenced this pull request Feb 11, 2018
gkalpak added a commit to petebacondarwin/angular that referenced this pull request Feb 11, 2018
gkalpak added a commit to petebacondarwin/angular that referenced this pull request Feb 11, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
amiel added a commit to amiel/ember-data-url-templates that referenced this pull request Apr 13, 2018
This fix is based on the suggestions from travis-ci/travis-ci#9024 (comment) and travis-ci/travis-ci#8836 (comment).

If using `sudo: false` is undesirable, it appears that there is another potential solution: angular/angular#21641
frett added a commit to CruGlobal/mobile-content-admin that referenced this pull request Jun 29, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants