fix(core): add support for ES2015 constructor delegation #24156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change adds better support for native ES2015 targets. The previous behavior didn't detect parameter delegation of constructor-less classes containing at least one inline property initialization before compilation.
|
Hi @ts2do - are you interested in working more on this PR to get it merged? I see that your repository has disappeared so I guess that you may not be working with Angular any more? |
|
@petebacondarwin this problem may have been resolved in angular 8 at around beta 9 or thereabouts. Best to re-test with one if the 8 rc's before devoting too much time to it. |
|
Yeah, I believe this fixed it #29232 |
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
May 9, 2019
This commit moves the delegated constructor detection to a helper function and also adds more test coverage. The original code for this came from angular#24156 thanks to @ts2do. Closes angular#24156 Closes angular#27267 // FW-1310
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ngular#30368) This commit moves the delegated constructor detection to a helper function and also adds more test coverage. The original code for this came from angular#24156 thanks to @ts2do. Closes angular#24156 Closes angular#27267 // FW-1310 PR Close angular#30368
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds better support for native ES2015 targets. The previous
behavior didn't detect parameter delegation of constructor-less classes
containing at least one inline property initialization before
compilation.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The following TypeScript code would incorrectly discard
Parent's ctorParameters when compiled targeting ES2015, causing a runtime error when instantiated. See issue Dependency injection does not work with es2015 target in angular/material2.What is the new behavior?
The above case should now be handled properly.
Does this PR introduce a breaking change?