fix(docs-infra): configure Firebase to strip off the .html extension
#25999
+29
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 52f3a71 at https://pr25999-52f3a71.ngbuilds.io/. |
petebacondarwin
approved these changes
Sep 18, 2018
Not afaict 😁
Not afaict. Actually, I inteded to add an e2e test, but forgot it. I'll add it later. |
|
Blocked on #25997 (for patch branch). |
Firebase used to do it automatically (with `cleanUrls: true`), but it stopped doing it unless the resulting URL corresponds to an existing file (which is not always the case in angular.io; e.g. the resulting URL might be matched by a new redirect rule). This change in Firebase hosting behavior resulted in some URLs not being correctly redirected (e.g. URLs to the archived v2 site, or `.html` suffixed URLs from 3rd-party sites). This commit fixes it, by configuring Firebase hosting to strip off the `.html` extension and redirect (if no other redirect rule matched).
52f3a71 to
764717a
Compare
|
You can preview 764717a at https://pr25999-764717a.ngbuilds.io/. |
|
Rebased on master and added an e2e test. This should be good to go once #25997 is merged. |
| page.sitemapUrls.forEach((url, i) => { | ||
| it(`should not redirect '${url}' (${i + 1}/${page.sitemapUrls.length})`, async () => { | ||
| await page.goTo(url); | ||
| page.sitemapUrls.forEach((path, i) => { |
There was a problem hiding this comment.
For clarity 😇
These are paths and it didn't read correctly to have baseUrl + url --> someUrl.
path is a more accurate name for what this variable holds 😃
petebacondarwin
approved these changes
Sep 19, 2018
IgorMinar
approved these changes
Sep 19, 2018
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Sep 20, 2018
angular#25999) Firebase used to do it automatically (with `cleanUrls: true`), but it stopped doing it unless the resulting URL corresponds to an existing file (which is not always the case in angular.io; e.g. the resulting URL might be matched by a new redirect rule). This change in Firebase hosting behavior resulted in some URLs not being correctly redirected (e.g. URLs to the archived v2 site, or `.html` suffixed URLs from 3rd-party sites). This commit fixes it, by configuring Firebase hosting to strip off the `.html` extension and redirect (if no other redirect rule matched). PR Close angular#25999
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Oct 1, 2018
angular#25999) Firebase used to do it automatically (with `cleanUrls: true`), but it stopped doing it unless the resulting URL corresponds to an existing file (which is not always the case in angular.io; e.g. the resulting URL might be matched by a new redirect rule). This change in Firebase hosting behavior resulted in some URLs not being correctly redirected (e.g. URLs to the archived v2 site, or `.html` suffixed URLs from 3rd-party sites). This commit fixes it, by configuring Firebase hosting to strip off the `.html` extension and redirect (if no other redirect rule matched). PR Close angular#25999
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Oct 1, 2018
angular#25999) Firebase used to do it automatically (with `cleanUrls: true`), but it stopped doing it unless the resulting URL corresponds to an existing file (which is not always the case in angular.io; e.g. the resulting URL might be matched by a new redirect rule). This change in Firebase hosting behavior resulted in some URLs not being correctly redirected (e.g. URLs to the archived v2 site, or `.html` suffixed URLs from 3rd-party sites). This commit fixes it, by configuring Firebase hosting to strip off the `.html` extension and redirect (if no other redirect rule matched). PR Close angular#25999
alxhub
pushed a commit
that referenced
this pull request
Oct 3, 2018
#25999) (#25997) Firebase used to do it automatically (with `cleanUrls: true`), but it stopped doing it unless the resulting URL corresponds to an existing file (which is not always the case in angular.io; e.g. the resulting URL might be matched by a new redirect rule). This change in Firebase hosting behavior resulted in some URLs not being correctly redirected (e.g. URLs to the archived v2 site, or `.html` suffixed URLs from 3rd-party sites). This commit fixes it, by configuring Firebase hosting to strip off the `.html` extension and redirect (if no other redirect rule matched). PR Close #25999 PR Close #25997
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
angular#25999) Firebase used to do it automatically (with `cleanUrls: true`), but it stopped doing it unless the resulting URL corresponds to an existing file (which is not always the case in angular.io; e.g. the resulting URL might be matched by a new redirect rule). This change in Firebase hosting behavior resulted in some URLs not being correctly redirected (e.g. URLs to the archived v2 site, or `.html` suffixed URLs from 3rd-party sites). This commit fixes it, by configuring Firebase hosting to strip off the `.html` extension and redirect (if no other redirect rule matched). PR Close angular#25999
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase used to do it automatically (with
cleanUrls: true), but it stopped doing it unless the resulting URL corresponds to an existing file (which is not always the case in angular.io; e.g. the resulting URL might be matched by a new redirect rule).This change in Firebase hosting behavior resulted in some URLs not being correctly redirected (e.g. URLs to the archived v2 site, or
.htmlsuffixed URLs from 3rd-party sites).This commit fixes it, by configuring Firebase hosting to strip off the
.htmlextension and redirect (if no other redirect rule matched).