[6.1.x] update angular.io to the new ServiceWorker #25997

gkalpak · 2018-09-18T12:15:57Z

This essentially backports #19795 to 6.1.x.
(Related: Jira FW-289)

googlebot · 2018-09-18T12:18:03Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

mary-poppins · 2018-09-18T12:23:40Z

You can preview a95c21f at https://pr25997-a95c21f.ngbuilds.io/.

gkalpak · 2018-09-20T08:48:49Z

Rebased on master and backported #25999.

mary-poppins · 2018-09-20T08:56:55Z

You can preview bf84855 at https://pr25997-bf84855.ngbuilds.io/.

gkalpak · 2018-09-24T20:09:13Z

This should be updated to incorporate #26042 once that is released.
UPDATE: #26145 includes the fix from #26042 and should be backported into this PR once merged.

mary-poppins · 2018-10-01T17:50:01Z

You can preview 9824792 at https://pr25997-9824792.ngbuilds.io/.

gkalpak · 2018-10-01T19:01:33Z

Backported #26145 into this PR.
This is now failing, because #26136 hasn't be backported to patch 😕
UPDATE: Merged now as 66c2d08.

AIO is currently using a beta version of @angular/service-worker. Since that was implemented, the SW has been rewritten and released as part of Angular 5.0.0. This commit updates AIO to use the latest implementation, with an appropriate configuration file that caches the various AIO assets in useful ways.

googlebot · 2018-10-03T20:24:55Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

…25997) AIO is currently using a beta version of @angular/service-worker. Since that was implemented, the SW has been rewritten and released as part of Angular 5.0.0. This commit updates AIO to use the latest implementation, with an appropriate configuration file that caches the various AIO assets in useful ways. PR Close #25997

PR Close #25997

…#25997) PR Close #25997

…5997) PR Close #25997

PR Close #25997

) PR Close #25997

PR Close #25997

…vkit/build-angular to 0.7.0-rc.3 (#25997) PR Close #25997

…#25997) PR Close #25997

…25997) The is a bug in versions 0.6.8+ that breaks when trying to use Jasmine's mock clock. Related to angular/angular-cli#11626. PR Close #25997

This allows URLs to be passed through to the server (where they are properly redirected), instead of serving `index.html` from the SW. Known issue: `/docs/` will be passed through to the server. `/docs` (without the trailing slash) will be correctly treated as a navigation URL and handled by the SW. We don't link to `/docs/` from within the app, but if there are external links to `/docs/` they will require a round-trip to the server and will not work in offline mode. PR Close #25997

PR Close #25997

#25999) (#25997) Firebase used to do it automatically (with `cleanUrls: true`), but it stopped doing it unless the resulting URL corresponds to an existing file (which is not always the case in angular.io; e.g. the resulting URL might be matched by a new redirect rule). This change in Firebase hosting behavior resulted in some URLs not being correctly redirected (e.g. URLs to the archived v2 site, or `.html` suffixed URLs from 3rd-party sites). This commit fixes it, by configuring Firebase hosting to strip off the `.html` extension and redirect (if no other redirect rule matched). PR Close #25999 PR Close #25997

…us (#26145) (#25997) PR Close #26145 PR Close #25997

PR Close #26145 PR Close #25997

gkalpak · 2018-10-03T21:02:56Z

This seems to have been merged. Closing...

angular-automatic-lock-bot · 2019-09-14T02:52:14Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

gkalpak changed the base branch from master to 6.1.x September 18, 2018 12:16

gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra labels Sep 18, 2018

googlebot added the cla: no label Sep 18, 2018

This was referenced Sep 18, 2018

fix(docs-infra): configure Firebase to strip off the .html extension #25999

Closed

https://angular.io/guide/reactive-forms shows empty page #24973

Closed

gkalpak force-pushed the 6.1.x-build-aio-new-sw branch from a95c21f to bf84855 Compare September 20, 2018 08:48

gkalpak mentioned this pull request Sep 20, 2018

angular.io website fail to search in firefox #26018

Closed

This was referenced Sep 27, 2018

HTTP 503 in Chrome -- angular.io is currently unable to handle this request. #25834

Closed

build(docs_app): upgrade to latest SW and other fixes ReactiveX/rxjs#4201

Merged

gkalpak added the state: blocked label Oct 1, 2018

gkalpak force-pushed the 6.1.x-build-aio-new-sw branch from bf84855 to 9824792 Compare October 1, 2018 17:41

alxhub and others added 10 commits October 1, 2018 23:25

refactor(docs-infra): remove unused images

62adffb

refactor(docs-infra): move concept icons to more appropriate location

41922aa

fix(docs-infra): correctly show icon for fetch error when offline

ccd0291

build(docs-infra): enable ServiceWorker in cli config

7c6acc9

build(docs-infra): remove the dependency on rxjs-compat

8993150

build(docs-infra): remove unused dependencies

19fa9d2

build(docs-infra): upgrade @angular/cli to 6.0.3

aaa4b9e

build(docs-infra): upgrade @angular/* to 6.0.2 and rxjs to 6.1.0

2b20689

build(docs-infra): upgrade @angular/material to 6.0.2

d8d7bf8

IgorMinar approved these changes Oct 3, 2018

View reviewed changes

IgorMinar added cla: yes and removed cla: no labels Oct 3, 2018

IgorMinar added the action: merge The PR is ready for merge by the caretaker label Oct 3, 2018

alxhub pushed a commit that referenced this pull request Oct 3, 2018

refactor(docs-infra): remove unused images (#25997)

31f352c

PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

refactor(docs-infra): move concept icons to more appropriate location (…

bc27b95

…#25997) PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

fix(docs-infra): correctly show icon for fetch error when offline (#2…

00b3731

…5997) PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): enable ServiceWorker in cli config (#25997)

5c84b91

PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): remove the dependency on rxjs-compat (#25997)

fefa171

PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): remove unused dependencies (#25997)

bc73dcb

PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): upgrade @angular/cli to 6.0.3 (#25997)

94b2673

PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): upgrade @angular/* to 6.0.2 and rxjs to 6.1.0 (#25997

8cbebc6

) PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): upgrade @angular/material to 6.0.2 (#25997)

115c874

PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): upgrade @angular/cli to 6.1.0-rc.3 and @angular-de…

82fcb32

…vkit/build-angular to 0.7.0-rc.3 (#25997) PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): upgrade @angular/* to 6.1.0-rc.3 and rxjs to 6.2.2 (…

7d45386

…#25997) PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): update size limits (#25997)

a68c29d

PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): update payload size limits to reflect current stat…

1975c0a

…us (#26145) (#25997) PR Close #26145 PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): upgrade @angular/* to 7.0.0-beta.7 (#26145) (#25997)

fe0c5bf

PR Close #26145 PR Close #25997

alxhub pushed a commit that referenced this pull request Oct 3, 2018

build(docs-infra): upgrade @angular/cli to 6.2.3 (#26145) (#25997)

d815e41

PR Close #26145 PR Close #25997

gkalpak closed this Oct 3, 2018

gkalpak deleted the 6.1.x-build-aio-new-sw branch October 5, 2018 08:31

petebacondarwin mentioned this pull request Jan 23, 2019

rxjs.dev 503 error after browsing several pages ReactiveX/rxjs#4482

Closed

1 task

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[6.1.x] update angular.io to the new ServiceWorker #25997

[6.1.x] update angular.io to the new ServiceWorker #25997

gkalpak commented Sep 18, 2018

googlebot commented Sep 18, 2018

mary-poppins commented Sep 18, 2018

gkalpak commented Sep 20, 2018

mary-poppins commented Sep 20, 2018

gkalpak commented Sep 24, 2018 •

edited

Loading

mary-poppins commented Oct 1, 2018

gkalpak commented Oct 1, 2018 •

edited

Loading

googlebot commented Oct 3, 2018

gkalpak commented Oct 3, 2018

angular-automatic-lock-bot bot commented Sep 14, 2019

[6.1.x] update angular.io to the new ServiceWorker #25997

[6.1.x] update angular.io to the new ServiceWorker #25997

Conversation

gkalpak commented Sep 18, 2018

googlebot commented Sep 18, 2018

mary-poppins commented Sep 18, 2018

gkalpak commented Sep 20, 2018

mary-poppins commented Sep 20, 2018

gkalpak commented Sep 24, 2018 • edited Loading

mary-poppins commented Oct 1, 2018

gkalpak commented Oct 1, 2018 • edited Loading

googlebot commented Oct 3, 2018

gkalpak commented Oct 3, 2018

angular-automatic-lock-bot bot commented Sep 14, 2019

gkalpak commented Sep 24, 2018 •

edited

Loading

gkalpak commented Oct 1, 2018 •

edited

Loading