feat!: angular-eslint v20 #2448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 4de9342.
☁️ Nx Cloud last updated this comment at |
|
@reduckted Please see 51691cf an existing test case of yours causes a parse error now after your PR to switch them on by default |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (82.82%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2448 +/- ##
==========================================
- Coverage 92.88% 92.62% -0.27%
==========================================
Files 200 202 +2
Lines 4232 4272 +40
Branches 996 1002 +6
==========================================
+ Hits 3931 3957 +26
- Misses 232 245 +13
- Partials 69 70 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixed in #2450. |
19311a3 to
cbd76c4
Compare
d29cd95 to
c495e5d
Compare
18 tasks
1fd2730 to
17c56ad
Compare
17 tasks
20fd42c to
cc39c58
Compare
cc39c58 to
15748a7
Compare
FrozenPandaz
pushed a commit
to nrwl/nx
that referenced
this pull request
Jun 6, 2025
Add support for Angular v20. BREAKING CHANGE: Support for Angular v17 was dropped. ### TODO - [x] Update Angular packages to the stable v20 - [x] Update `jest-preset-angular` when it releases support for Angular v20 - [x] PR: thymikee/jest-preset-angular#3119 - [x] Release: https://github.com/thymikee/jest-preset-angular/releases/tag/v14.6.0 - [ ] Update Angular ESLint packages to the v20 stable version once released - [ ] PR: angular-eslint/angular-eslint#2448 - [x] Update AnalogJS packages when they are released with support for Angular v20 - [x] PR: analogjs/analog#1751 - [x] Release: https://github.com/analogjs/analog/releases/tag/v1.17.0 - [x] Fix for `@analogjs/vitest-angular` peer deps: analogjs/analog#1754 - [x] Release: - [x] Beta: https://github.com/analogjs/analog/releases/tag/v1.17.1-beta.1 - [x] Stable: https://github.com/analogjs/analog/releases/tag/v1.17.1 - [ ] Update Storybook packages - [x] PRs: storybookjs/storybook#31602 and storybookjs/storybook#31611 - [x] Storybook 9 Release: https://github.com/storybookjs/storybook/releases/tag/v9.0.3 - [ ] Storybook 8 Release??: PENDING - [ ] Remaining issue: storybookjs/storybook#31652
|
I have run out of time before I am on vacation for a week without a laptop so this needs to go out now :) |
ndcunningham
pushed a commit
to nrwl/nx
that referenced
this pull request
Jul 30, 2025
Add support for Angular v20. BREAKING CHANGE: Support for Angular v17 was dropped. ### TODO - [x] Update Angular packages to the stable v20 - [x] Update `jest-preset-angular` when it releases support for Angular v20 - [x] PR: thymikee/jest-preset-angular#3119 - [x] Release: https://github.com/thymikee/jest-preset-angular/releases/tag/v14.6.0 - [ ] Update Angular ESLint packages to the v20 stable version once released - [ ] PR: angular-eslint/angular-eslint#2448 - [x] Update AnalogJS packages when they are released with support for Angular v20 - [x] PR: analogjs/analog#1751 - [x] Release: https://github.com/analogjs/analog/releases/tag/v1.17.0 - [x] Fix for `@analogjs/vitest-angular` peer deps: analogjs/analog#1754 - [x] Release: - [x] Beta: https://github.com/analogjs/analog/releases/tag/v1.17.1-beta.1 - [x] Stable: https://github.com/analogjs/analog/releases/tag/v1.17.1 - [ ] Update Storybook packages - [x] PRs: storybookjs/storybook#31602 and storybookjs/storybook#31611 - [x] Storybook 9 Release: https://github.com/storybookjs/storybook/releases/tag/v9.0.3 - [ ] Storybook 8 Release??: PENDING - [ ] Remaining issue: storybookjs/storybook#31652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contents of this branch are already available to use under the
prerelease-v20dist tag on npm:https://www.npmjs.com/package/angular-eslint/v/prerelease-v20
Final Items before
20.0.0:## TODOsCompleted Items^20.19.0 || ^22.12.0 || ^24.0.05.8to align with Angular v20prefer-standalone([@angular-eslint/prefer-standalone] The ruleprefer-standaloneshould not be "fixable" #2206)@angular-eslint/component-class-suffixfrom recommended to align with v20 style guide and CLI code generation@angular-eslint/directive-class-suffixfrom recommended to align with v20 style guide and CLI code generation@angular-eslint/prefer-injectfrom feat(eslint-plugin): [prefer-inject] add new rule #2461 to the recommended configFixes #2206
FIxes #2481