-
Notifications
You must be signed in to change notification settings - Fork 215
refactor: remove explicit public access modifiers #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @beeman, just checking in with you, could you provide me a status on this PR? |
@Jefiozie it got stuck due to a discussion we had what public meant.
|
Well, this is about code esthetics, as there is no actual difference in having the public in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before merging this we should resolve the conflict. Also I would opt to add a eslint rule that explicit defines what should be defined and what not. In this case I would also opt to remove all public keywords. I will add a comment on the linting issue to make sure that we add this rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Jefiozie Done, also removed a couple more stray 'puclic''s ;) |
No description provided.