Fix(resetSearchInput) change search box doesn't clear after selecting #1746
Conversation
|
@Jefiozie I noticed that if you click an item it doesn't refocus the search area so you can't type in unless you manually click. Repro. Steps:
http://plnkr.co/edit/Cc9XuVRwWHWpVYpbIKCs?p=preview It works if you select with keyboard navigation though |
|
Hi @user378230, I see it is not focusing the control . Should it always refocus on the control after selecting a option? Or should this only be done if multiple is enabled? p.s. the plunker you shared used v 0.13.1 btw |
|
I didn't check single select use case actually but I think it should only refocus in multiple case. (I don't think people use And plunkr is against 0.19.4 I used can to update existing example from someone. 😛 |
|
Okay I will fix it, when the |
|
Thanks! If you could make plunkr with fixed version we can double check single select scenario too just to be sure 😃 |
|
I think this will do? Plunker focus |
…angular-ui#1746) * fix(resetSearchInput) change search box doesn't clear after selecting * Removed extra blank line
This PR is instead of #1725.
Previously when the closeOnSelect was set to false the resetSearchInput was not executed after selecting a item even when resetSearchInput was set to true.
This fix will always execute the resetSearchInput when set to true even with the closeOnSelect set to false.
I believe this will fix #1484, #1083 , #1384, #777 and is making sure that #1015 is not needed.
@user378230 Did not test #1083 but as I believe will be fixed.