-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(resetSearchInput) multiple didn't clear after selecting #1761
Conversation
Added some unit test to prevent problems in the future. |
Did you intend to make that many changes? I've not pulled down to review yet just wondering if maybe you broke some whitespacing or something. And, as always, thanks for your work/patience 👍 |
This reverts commit 580145a.
@user378230 think I used auto format reverted the commit and added the new tests. These will check if the multiple ui-select is working with resetSearchInput. Just read the wiki and there resetSearchInput is default set true. You want me to change the code or the wiki? |
Thanks for the fix @Jefiozie @aaronroberson any chance this can be merged and a new release cut? |
Merged. Will test to see if the travis hooks will update the version and publish to NPM. |
thanks @aaronroberson looks like Travis failed to publish with:
|
@aaronroberson, thanks for merging this 😄. I will update the wiki as the resetsearchinput is default false. |
Thanks @timelf123 and @Jefiozie! v0.19.3 is now available :D |
thanks @aaronroberson for the quick merge! can you |
We should really revert the default back to |
@Jefiozie Can you create a PR to revert the default to |
@aaronroberson Sure no problem! |
…ui#1761) * fix(resetSearchInput) multiple didn't clear after selecting Closes angular-ui#1760
This will fix #1760
Still I don't have any tests @user378230 any thoughts on this.
Did try some stuff but didn't succeed.