Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Conversation

Jefiozie
Copy link
Contributor

This will fix #1760

Still I don't have any tests @user378230 any thoughts on this.
Did try some stuff but didn't succeed.

@Jefiozie
Copy link
Contributor Author

Added some unit test to prevent problems in the future.
Still don't know if this is the best way to validate the resetSearch function, would love to see some feedback 😄

@user378230
Copy link
Contributor

user378230 commented Aug 15, 2016

1,226 test/select.spec.js
630 additions, 596 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

Did you intend to make that many changes? I've not pulled down to review yet just wondering if maybe you broke some whitespacing or something.

And, as always, thanks for your work/patience 👍

@Jefiozie
Copy link
Contributor Author

Jefiozie commented Aug 15, 2016

@user378230 think I used auto format reverted the commit and added the new tests. These will check if the multiple ui-select is working with resetSearchInput.

Just read the wiki and there resetSearchInput is default set true. You want me to change the code or the wiki?

@timelf123
Copy link

timelf123 commented Aug 16, 2016

Thanks for the fix @Jefiozie

@aaronroberson any chance this can be merged and a new release cut?

@aaronroberson aaronroberson merged commit 0bcd70a into angular-ui:master Aug 16, 2016
@aaronroberson
Copy link
Contributor

Merged. Will test to see if the travis hooks will update the version and publish to NPM.

@timelf123
Copy link

timelf123 commented Aug 16, 2016

thanks @aaronroberson looks like Travis failed to publish with:

Skipping a deployment with the script provider because this is not a tagged commit
Skipping a deployment with the npm provider because this is not a tagged commit

@Jefiozie
Copy link
Contributor Author

@aaronroberson, thanks for merging this 😄. I will update the wiki as the resetsearchinput is default false.

@aaronroberson
Copy link
Contributor

Thanks @timelf123 and @Jefiozie! v0.19.3 is now available :D

@timelf123
Copy link

thanks @aaronroberson for the quick merge! can you git tag 0.19.3 && git push --tags?

@user378230
Copy link
Contributor

We should really revert the default back to true

@aaronroberson
Copy link
Contributor

@Jefiozie Can you create a PR to revert the default to true?

@Jefiozie
Copy link
Contributor Author

@aaronroberson Sure no problem!

@Jefiozie Jefiozie deleted the issue_1760 branch August 17, 2016 06:10
kboga pushed a commit to kboga/ui-select that referenced this pull request Nov 29, 2016
…ui#1761)

* fix(resetSearchInput) multiple didn't clear after selecting

Closes angular-ui#1760
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in multiple select mode, the search text is not cleared until you focus on the input again
4 participants