Skip to content

Added Date Night theme to index.js #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2022

Conversation

jesterb0206
Copy link
Contributor

Hi Anurag or whoever is reading this,

I have a new theme that I would like to contribute to the GitHub README Stats repository, I hope you enjoy!

Bradley

dateNight Theme

@vercel
Copy link

vercel bot commented Nov 14, 2022

@jesterb0206 is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Nov 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ date_night

Result: ✔️ All themes are valid.

Details

Date_night theme preview

title_color: #DA7885 | icon_color: #BB8470 | text_color: #E1B2A2 | bg_color: #170F0C | border_color: #170F0C

Preview Link

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some themes are invalid. See the Automated Theme Preview comment above for more information.

@github-actions github-actions bot added the invalid The bug/issue caused by minor mistakes. label Nov 14, 2022
@github-actions github-actions bot removed the invalid The bug/issue caused by minor mistakes. label Nov 14, 2022
@rickstaa rickstaa merged commit 0e02523 into anuraghazra:master Nov 19, 2022
@jesterb0206 jesterb0206 deleted the date-night-theme branch November 19, 2022 22:34
@jesterb0206
Copy link
Contributor Author

@rickstaa One question, will it be added to themes/README.md? Sorry to be a pest

@rickstaa
Copy link
Collaborator

rickstaa commented Nov 20, 2022

@jesterb0206 I understand your confusion. Our generate-theme-doc.yml) should create a PRs for updating the Themes list. I, however, noticed that these PRs failed in the last months. @anuraghazra, Can you maybe check what is going on or trigger this action manually?

@rickstaa
Copy link
Collaborator

@jesterb0206 @anuraghazra Looks like the action fails with an npm not found action but doesn't throw an error exit code.

@rickstaa
Copy link
Collaborator

rickstaa commented Nov 20, 2022

@anuraghazra Why do you force a 0 exit code when something goes wrong?

git commit --message "docs(theme): Auto update theme readme" || exit 0

Further, I think we should use the --no-verify command to prevent this error from happening.

- git commit --message "docs(theme): Auto update theme readme" || exit 0
+ git commit --no-verify --message "docs(theme): Auto update theme readme"

@rickstaa
Copy link
Collaborator

@anuraghazra I created https://github.com/anuraghazra/github-readme-stats/pull/2271/files to fix this. Can you maybe take a look?

devantler pushed a commit to devantler/github-readme-stats that referenced this pull request May 1, 2023
* Added Date Night theme to index.js

* My theme name should be in snake_case now
necofuryai added a commit to necofuryai/github-readme-stats that referenced this pull request May 19, 2025
* Added Date Night theme to index.js

* My theme name should be in snake_case now
xhayper pushed a commit to xhayper/github-readme-stats that referenced this pull request Jul 2, 2025
* Added Date Night theme to index.js

* My theme name should be in snake_case now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants