-
-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Added Date Night theme to index.js #2264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jesterb0206 is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Automated Theme PreviewHi, thanks for the theme contribution. Please read our theme contribution guidelines. We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.
✔️ Theme PR does adhere to our guidelines. Test results
Result: ✔️ All themes are valid. DetailsDate_night theme previewtitle_color: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some themes are invalid. See the Automated Theme Preview comment above for more information.
@rickstaa One question, will it be added to themes/README.md? Sorry to be a pest |
@jesterb0206 I understand your confusion. Our generate-theme-doc.yml) should create a PRs for updating the Themes list. I, however, noticed that these PRs failed in the last months. @anuraghazra, Can you maybe check what is going on or trigger this action manually? |
@jesterb0206 @anuraghazra Looks like the action fails with an |
@anuraghazra Why do you force a
Further, I think we should use the - git commit --message "docs(theme): Auto update theme readme" || exit 0
+ git commit --no-verify --message "docs(theme): Auto update theme readme" |
@anuraghazra I created https://github.com/anuraghazra/github-readme-stats/pull/2271/files to fix this. Can you maybe take a look? |
* Added Date Night theme to index.js * My theme name should be in snake_case now
* Added Date Night theme to index.js * My theme name should be in snake_case now
* Added Date Night theme to index.js * My theme name should be in snake_case now
Hi Anurag or whoever is reading this,
I have a new theme that I would like to contribute to the GitHub README Stats repository, I hope you enjoy!
Bradley