Fix vector index missing in telemetrics #21788
Conversation
| "edge", "geo", "hash", "fulltext", "inverted", | ||
| "persistent", "skiplist", "ttl", "mdi", "mdi-prefixed", | ||
| "iresearch", "primary", "unknown"}; | ||
| "iresearch", "primary", "vector", "unknown"}; |
There was a problem hiding this comment.
For telemetry schema consistency, we need to always report the vector index here, regardless of whether it is used or not.
| return { | ||
| setUpAll: function () { | ||
| db._create(cn); | ||
| let coll = db._createEdgeCollection(cn3, {numberOfShards: 2}); |
There was a problem hiding this comment.
Is there a reason why the edge collection has 2 shards and the document collection has one?
There was a problem hiding this comment.
Nope I forgot about it. I will remove the uneeded stuff from the setup
|
|
||
| function validateObjectAgainstSchema(obj, fieldDefinitions, currentPath) { | ||
| let allErrors = []; | ||
| const dataKeys = new Set(Object.keys(obj)); |
There was a problem hiding this comment.
I don't see why we need this variable
There was a problem hiding this comment.
allErrors reports all found violations agains schema and dataKeys severs to check if some fields are duplicates
There was a problem hiding this comment.
But you are just creating this set and delete stuff in it, you never read from it, therefore I am confused.
There was a problem hiding this comment.
Ah you are right. I missed that. Will fix it
| if (mode !== "NULLABLE" && mode !== "REPEATED") { | ||
| // This case is for fields that are implicitly "REQUIRED". | ||
| // Given the schema's explicit modes, this path usually means the field is optional. | ||
| // errors.push(`Error at "${path}": Field is required but missing.`); |
There was a problem hiding this comment.
why is this commented out? if it stays like this, we don't need this case.
Scope & Purpose
Vector index
n_vectorwas missing in telemetrics is now added.Checklist
Related Information
(Please reference tickets / specification / other PRs etc)