Skip to content

Fix version number of metrics and startup options added as part of RocksDB upgrade #21799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

Fix version number of metrics and startup options added as part of RocksDB upgrade #21799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51cb7fd
Fix version number of metrics added as part of RocksDB upgrade
Simran-B Jun 10, 2025
5e607b0
Actually not in 3.12.5 branch
Simran-B Jun 10, 2025
3130688
Adjust version remarks for newly added startup options too
Simran-B Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Documentation/Metrics/rocksdb_block_cache_charge_per_entry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: rocksdb_block_cache_charge_per_entry
introducedIn: "3.12.2"
introducedIn: "3.12.6"
help: |
Average size of entries in RocksDB block cache.
unit: bytes
Expand Down
2 changes: 1 addition & 1 deletion Documentation/Metrics/rocksdb_block_cache_entries.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: rocksdb_block_cache_entries
introducedIn: "3.12.2"
introducedIn: "3.12.6"
help: |
Number of entries in the RocksDB block cache.
unit: number
Expand Down
2 changes: 1 addition & 1 deletion Documentation/Metrics/rocksdb_live_blob_file_garbage_size.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: rocksdb_live_blob_file_garbage_size
introducedIn: "3.12.2"
introducedIn: "3.12.6"
help: |
Size of garbage in live RocksDB .blob files.
unit: bytes
Expand Down
2 changes: 1 addition & 1 deletion Documentation/Metrics/rocksdb_live_blob_file_size.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: rocksdb_live_blob_file_size
introducedIn: "3.12.2"
introducedIn: "3.12.6"
help: |
Size of live RocksDB .blob files.
unit: bytes
Expand Down
2 changes: 1 addition & 1 deletion Documentation/Metrics/rocksdb_num_blob_files.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: rocksdb_num_blob_files
introducedIn: "3.12.2"
introducedIn: "3.12.6"
help: |
Number of live RocksDB .blob files.
unit: number
Expand Down
12 changes: 6 additions & 6 deletions arangod/RocksDBEngine/RocksDBOptionFeature.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ are stopped to allow compaction to catch up.)");
arangodb::options::Flags::OnAgent,
arangodb::options::Flags::OnDBServer,
arangodb::options::Flags::OnSingle))
.setIntroducedIn(31205);
.setIntroducedIn(31206);

TRI_ASSERT(::blockCacheTypes.contains(_blockCacheType));
options
Expand All @@ -799,7 +799,7 @@ are stopped to allow compaction to catch up.)");
"type is experimental).",
new DiscreteValuesParameter<StringParameter>(
&_blockCacheType, ::blockCacheTypes))
.setIntroducedIn(31205);
.setIntroducedIn(31206);

options
->addOption(
Expand Down Expand Up @@ -1131,7 +1131,7 @@ downgrading.)");
arangodb::options::Flags::OnAgent,
arangodb::options::Flags::OnDBServer,
arangodb::options::Flags::OnSingle))
.setIntroducedIn(31205);
.setIntroducedIn(31206);

options
->addOption("--rocksdb.enable-index-compression",
Expand Down Expand Up @@ -1169,7 +1169,7 @@ downgrading.)");
arangodb::options::Flags::OnAgent,
arangodb::options::Flags::OnDBServer,
arangodb::options::Flags::OnSingle))
.setIntroducedIn(31205);
.setIntroducedIn(31206);

options
->addOption("--rocksdb.min-blob-size",
Expand Down Expand Up @@ -1209,7 +1209,7 @@ downgrading.)");
arangodb::options::Flags::OnAgent,
arangodb::options::Flags::OnDBServer,
arangodb::options::Flags::OnSingle))
.setIntroducedIn(31205);
.setIntroducedIn(31206);

options
->addOption(
Expand Down Expand Up @@ -1287,7 +1287,7 @@ downgrading.)");
arangodb::options::Flags::OnAgent,
arangodb::options::Flags::OnDBServer,
arangodb::options::Flags::OnSingle))
.setIntroducedIn(31205);
.setIntroducedIn(31206);

options
->addOption(
Expand Down