Skip to content

update /metrics endpoint to v2 #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 2, 2024
Merged

update /metrics endpoint to v2 #313

merged 4 commits into from
Feb 2, 2024

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Dec 30, 2023 •
edited
Loading

Since ArangoDB 3.8, there have been two APIs for retrieving the metrics in two different formats: /_admin/metrics and /_admin/metrics/v2. The metrics API v1 (/_admin/metrics) was deprecated in 3.8 and the usage of /_admin/metrics/v2 was encouraged.

In ArangoDB 3.10, /_admin/metrics and /_admin/metrics/v2 now behave identically and return the same output in a fully Prometheus-compatible format. The old metrics format is not available anymore.

Ref: https://docs.arangodb.com/3.11/release-notes/version-3.10/api-changes-in-3-10/#endpoint-return-value-changes

@aMahanna aMahanna changed the title update /metrics endpoint to v2 update: /metrics endpoint to v2 Jan 19, 2024
@aMahanna aMahanna changed the title update: /metrics endpoint to v2 wip: update /metrics endpoint to v2 Jan 19, 2024
@aMahanna aMahanna changed the title wip: update /metrics endpoint to v2 update /metrics endpoint to v2 Jan 25, 2024
apetenchea
apetenchea approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@apetenchea apetenchea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aMahanna aMahanna merged commit 97bf6d8 into main Feb 2, 2024
@aMahanna aMahanna deleted the update-metrics-endpoint branch February 2, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apetenchea apetenchea apetenchea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aMahanna @apetenchea