This repository was archived by the owner on Dec 15, 2022. It is now read-only.
add more test cases for lambda tokenization #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grammars/python.cson
Outdated
| @@ -335,7 +335,7 @@ | |||
| ] | |||
| } | |||
| { | |||
| 'begin': '\\b(lambda)\\s?+' | |||
| 'begin': '\\b(lambda)(?=[\\s\\:])' | |||
There was a problem hiding this comment.
Would something as simple as a word boundary anchor (\b) work here, or do you need the lookahead?
There was a problem hiding this comment.
That s a very good point! Let me push a new commit
|
Thanks for following up on the |
|
Sure thing! I happen to see that in my code just now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Matches
lambdavia lookahead for whitespace or:. This resolves #246 and a problem introduced in #253Alternate Designs
Benefits
Possible Drawbacks
Applicable Issues
#253 broke parsing
lambda_not.foo. This fixes it while preserving correct tokenization for #246