Add python nosetests #105

cchampet · 2014-10-07T12:07:05Z

16 tests.
Travis: launch tests after build.
Update python module and avtranscoder python library.
fix Add nosetests #76

* Contains 2 nose-tests: * testAddMetadataDate: add metadata 'date' to the outputFile. * testAddMetadataPlo: check if metadata 'plop' is not added to the outputFile.

* Add 6 nose-tests about dummy. * Add 2 nose-tests about rewrap. * Add 6 nose-tests about transcode.

…into dev_pyTest

* Modules are in lower cases (python...). * Install python module in site-packages/pyAvTranscoder directory. * Update import of avtranscoder module for pyTests.

For Python binding, need to compile the wrapper into a lib called _<module_name>.so

ProgressListener to NoDisplayProgress.

* Create a tuple which can be use after in the assert. * Rename testAddMetadataPlop to testAddImpossibleMetadata (update comment).

ProgressListener to NoDisplayProgress.

Two variables are used in tests: * AVTRANSCODER_TEST_AUDIO_FILE * AVTRANSCODER_TEST_VIDEO_FILE

* Temporary solution, to launch tests with Travis.

Comment this test because of a crash (due to pixel format YUV420).

Remove spaces and semicolons.

cchampet · 2014-10-07T12:58:40Z

Problem: Travis doesn't found nosetests command.

fabiencastan · 2014-10-07T14:48:40Z

apt-get install -qq python-nose

* Travis failed if tests failed. * Launch tests on Linux (with ffmpeg 2.2.9) and MacOS (with ffmpeg 2.2.3).

cchampet · 2014-10-21T13:31:36Z

I did not succeed to add and install the FFmpeg version I wanted with the daily updated package. Ubuntu took a too old FFmpeg version...
And I think this is a good thing to launch tests with exactly the FFmpeg version we want (and give as advice to the users to use the same version).
So I build FFmpeg 2.2.9 on Linux, and build Avtranscoder with it.
On MacOS, I found a bottles with FFmpeg 2.2.3, and build Avtranscoder with it (but currently Travis issue with MacOS maybe...).

cchampet · 2014-10-21T13:57:30Z

What do you think @MarcAntoine-Arnaud ? ;)

FFmpeg's homebrew formula is 2.4.2! No need to looking for a bottle of FFmpeg elsewhere.

* After audio rewrap, check: * format * the audio stream * After video rewrap, check: * format * the video stream

valnoel · 2014-10-23T12:46:20Z

src/AvTranscoder/codec/ICodec.cpp

-	avcodec_close( _codecContext );
-	av_free( _codecContext );
-	_codecContext = NULL;
+	if( ! _codecContext )


Would not it be if( _codecContext ) instead of if( ! _codecContext ) ?

agreed with @valnoel

Oh my mistake, so currently i free nothing !

* Close and free avcodec in destructor only if AVCodecContext and AVCodec are not NULL. * Generator Video / Audio: get a pointer to an ICodec, because we set its codec from the outside (method setVideoCodec / setAudioCodec). And this codec outside will be free elsewhere.

* Cast only one time (for video or audio cases). * Use reference when cast (it was not the case for video).

Add python nosetests

Clement Champetier added 17 commits September 1, 2014 11:55

PyTest: add testProperties

12c368e

* Contains 2 nose-tests: * testAddMetadataDate: add metadata 'date' to the outputFile. * testAddMetadataPlo: check if metadata 'plop' is not added to the outputFile.

PyTest: add testTranscoder for dummy/rewrap/transcode

9a613f6

* Add 6 nose-tests about dummy. * Add 2 nose-tests about rewrap. * Add 6 nose-tests about transcode.

Merge branch 'master' of https://github.com/avTranscoder/avTranscoder …

d2633b4

…into dev_pyTest

Swig: rename AvTranscoder to avtranscoder

c922917

* Modules are in lower cases (python...). * Install python module in site-packages/pyAvTranscoder directory. * Update import of avtranscoder module for pyTests.

Swig python: install __init__.py file

2a1aa88

Swig python: fix library name

d4eeef1

For Python binding, need to compile the wrapper into a lib called _<module_name>.so

pyTest testProperties: fit to new API

7cea2f1

ProgressListener to NoDisplayProgress.

pyTest testProperties: clean tests

5645fdd

* Create a tuple which can be use after in the assert. * Rename testAddMetadataPlop to testAddImpossibleMetadata (update comment).

pyTest testTranscoderDummy: fit to new API

c23d280

ProgressListener to NoDisplayProgress.

pyTest testTranscoderRewrap: fit to new API

851d4e8

ProgressListener to NoDisplayProgress.

pyTest testTranscoderTranscode: fit to new API

9c16cc3

ProgressListener to NoDisplayProgress.

pyTest: use environment variables to use files in tests

4528be0

Two variables are used in tests: * AVTRANSCODER_TEST_AUDIO_FILE * AVTRANSCODER_TEST_VIDEO_FILE

pyTest: comment tests which failed

c37387d

* Temporary solution, to launch tests with Travis.

Update README: add Tests section

2683fa1

Update README: remove Requirements section

fc0051b

pyTest testTranscoderTranscode: add testTranscodeYUV420

2e32a5f

Comment this test because of a crash (due to pixel format YUV420).

pyTest testTranscoderDummy: clean tests

aba8560

Remove spaces and semicolons.

cchampet force-pushed the dev_pyTest branch 5 times, most recently from cde969d to 034a085 Compare October 7, 2014 12:47

cchampet force-pushed the dev_pyTest branch 4 times, most recently from 3a0896d to d1e852a Compare October 8, 2014 15:27

Travis: launch python nosetests after build

a2463b1

cchampet force-pushed the dev_pyTest branch from d1e852a to a2463b1 Compare October 8, 2014 15:42

cchampet force-pushed the dev_pyTest branch 15 times, most recently from d7d06c5 to d3b3c56 Compare October 21, 2014 12:25

Travis: fix launch nosetests after build (linux)

d9f2e08

cchampet force-pushed the dev_pyTest branch from d3b3c56 to d9f2e08 Compare October 21, 2014 12:52

Travis: launch nosetests after MacOS build

b849d53

* Travis failed if tests failed. * Launch tests on Linux (with ffmpeg 2.2.9) and MacOS (with ffmpeg 2.2.3).

Clement Champetier added 3 commits October 22, 2014 19:08

pyTest testTranscoderRewrap: check video and audio streams properties

8a31d86

Travis: fix launch nosetests after build (macos)

5d1ebfd

FFmpeg's homebrew formula is 2.4.2! No need to looking for a bottle of FFmpeg elsewhere.

pyTest testTranscoderRewrap: clean testRewrap Video/Audio stream

b08bead

* After audio rewrap, check: * format * the audio stream * After video rewrap, check: * format * the video stream

valnoel reviewed Oct 23, 2014
View reviewed changes

Clement Champetier added 2 commits October 23, 2014 15:26

StreamTranscoder: clean constructor in case of generator essence

bae154c

* Cast only one time (for video or audio cases). * Use reference when cast (it was not the case for video).

cchampet force-pushed the dev_pyTest branch from 37f4189 to bae154c Compare October 23, 2014 13:29

MarcAntoine-Arnaud added a commit that referenced this pull request Oct 23, 2014

Merge pull request #105 from cchampet/dev_pyTest

1002196

Add python nosetests

MarcAntoine-Arnaud merged commit 1002196 into avTranscoder:master Oct 23, 2014

cchampet deleted the dev_pyTest branch October 27, 2014 10:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add python nosetests #105

Add python nosetests #105

Uh oh!

cchampet commented Oct 7, 2014

Uh oh!

cchampet commented Oct 7, 2014

Uh oh!

fabiencastan commented Oct 7, 2014

Uh oh!

cchampet commented Oct 21, 2014

Uh oh!

cchampet commented Oct 21, 2014

Uh oh!

valnoel Oct 23, 2014

Uh oh!

MarcAntoine-Arnaud Oct 23, 2014

Uh oh!

cchampet Oct 23, 2014

Uh oh!

Uh oh!

Add python nosetests #105

Add python nosetests #105

Uh oh!

Conversation

cchampet commented Oct 7, 2014

Uh oh!

cchampet commented Oct 7, 2014

Uh oh!

fabiencastan commented Oct 7, 2014

Uh oh!

cchampet commented Oct 21, 2014

Uh oh!

cchampet commented Oct 21, 2014

Uh oh!

valnoel Oct 23, 2014

Choose a reason for hiding this comment

Uh oh!

MarcAntoine-Arnaud Oct 23, 2014

Choose a reason for hiding this comment

Uh oh!

cchampet Oct 23, 2014

Choose a reason for hiding this comment

Uh oh!

Uh oh!