Reader: enable process with a generator #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 24, 2016 18:25
…o decode * New attribute: _continueWithGenerator * New method: continueWithGenerator
To be able to generate data (ie silence or black) when there is no more data to decode.
…empty frame * New attribute: _emptyFrame * This commit avoids issue when dstFrame was clear and we need to generate data after this instruction. The dstFrame must not be updated in this case!
* Unused. * Warning: after this instruction, we have to set again all fields of the Frame to use it. It is easier to create a new Frame.
| else | ||
| { | ||
| _generator->decodeNextFrame(*_srcFrame); | ||
| } |
There was a problem hiding this comment.
You could have done :
// generate data (ie silence or black)
if(_continueWithGenerator)
{
_generator->decodeNextFrame(*_srcFrame);
}
// or return an empty frame
else
{
_dstFrame->clear();
return _dstFrame;
}or
// return an empty frame
if(!_continueWithGenerator)
{
_dstFrame->clear();
return _dstFrame;
}
// or generate data (ie silence or black)
_generator->decodeNextFrame(*_srcFrame);Avoid 'if not'/'else': 'if'/'else' is easier.
|
See PR #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.