Skip to content

Fix gop properties #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 16, 2016
Merged

Fix gop properties #247

merged 21 commits into from
May 16, 2016

Conversation

cchampet
Copy link
Member

No description provided.

Clement Champetier added 21 commits May 13, 2016 11:17
Use VideoProperties::getProfile() method.
This check is already done by av_get_profile_name method.
* Use Frame class instead (allocation/free is managed by the class).
Use Frame::getEncodedSize() method.
* Use VideoProperties::getGopSize() instead.
* Add doc to this method.
* To get the level of analysis asked inside member methods.
* Will be used in the next commit.
* AVCodecContext->gop_size is unused when decode according to the ffmpeg
documentation:
https://ffmpeg.org/doxygen/2.8/structAVCodecContext.html#a9b6b3f1fcbdcc2ad9f4dbb4370496e38
* So compute this info when analyseGopStructure, and store it inside the
VideoProperties class.
* Because the gop size could be used inside getBitRate() method, throw a
runtime exception before using it.
* Before: picture type, is key frame
* After: picture type, encoded frame size in bytes
* Note: "is key frame" info can be found using the picture type (I
frame).
* Updated SWIG interface.
All properties have the same value if not found.
…t gop

All properties have the same value if not found.
Need to analyse first GOP to compute bitrate and get gop size of output.
@coveralls
Copy link

coveralls commented May 13, 2016

Coverage Status

Coverage decreased (-0.2%) to 74.528% when pulling 4d04f10 on cchampet:fix_gopProperties into 94c3b73 on avTranscoder:develop.

@valnoel valnoel merged commit f3b6f44 into avTranscoder:develop May 16, 2016
valnoel pushed a commit to valnoel/avTranscoder that referenced this pull request Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants