Skip to content

Transcoder: use complex filter to map several audio #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cchampet
Copy link
Member

No description provided.

Clement Champetier added 29 commits July 19, 2016 15:18
* To be able to read data from several source, and encode them in the
same output stream.
* This will be done in the next commits.
* _sourceBuffers to _decodedData.
* _frameBuffers to _convertedData.
To have a buffer of filtered data.
* In this case, '_inputStreams.size() == 1' is always true!
* Anyway, we should check the '_currentInputStream' attribute because it
is used in the method.
* No pointers are needed here.
* Updated FilterGraph parameters to launch a process.
Confusing when we will have several input streams.
The VideoFrameDesc could be found from the given frame when decoding.
The AudioFrameDesc could be found from the given frame when decoding.
* Add provate method 'addDecoder'.
* Will be used to add several decoders.
* Need pointers here to be able to use polymorphism.
* Updated FilterGraph parameters to launch a process.
* Almost a revert of commit ecd3ddd
The _currentDecoder could be one of the decoder in the _inputDecoders
list.
* Renamed private method 'getProfileFromFile' to 'getProfileFromInput'.
* Removed private method 'addTranscodeStream'.
refFrame method allocates new data that will be freed by calling clear
method or the destructor of the referenced frame.
Avoid switching if the current case is a generator.
After calling 'avcodec_decode_audio4', sometimes the channel layout of
the frame is set to 0. I could be a problem in the next steps of the
process.
2 inputs is the default value for this filter.
Added vector<InputStreamDesc> in the SWIG interface.
Clement Champetier added 4 commits July 20, 2016 18:37
* Need to have a description of the given frame buffer when decoding,
because the buffer could be invalid (clear at the end of decoding of an
other stream). This attribute could be seen as a backup.
* Almost a revert of commits 935ed64 and 924bf5b.
…into dev_transcoderUseComplexFilterToMapAudio

Conflicts:
	test/pyTest/testSetFrame.py
@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage increased (+0.2%) to 76.789% when pulling cc6d03f on cchampet:dev_transcoderUseComplexFilterToMapAudio into d09cc28 on avTranscoder:develop.

Clement Champetier added 12 commits July 21, 2016 12:48
This code was never reach, since the previous intructions already check
if the frame is a valid audio frame.
Better to check a more complicated case, when the encoding profile is
found from the inputs.
If channel_layout attribute is not indicated, the method returns the
default channel layout which corresponds to the given number of
channels.
To testAddAStreamFromAFileWhichDoesNotExist
The width and height should be added as string.
…puts

Added a python test to check this behavior.
…into dev_transcoderUseComplexFilterToMapAudio
@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Changes Unknown when pulling 2e61259 on cchampet:dev_transcoderUseComplexFilterToMapAudio into * on avTranscoder:develop*.

@cchampet cchampet merged commit 6e22771 into avTranscoder:develop Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants