-
Notifications
You must be signed in to change notification settings - Fork 50
Transcoder: use complex filter to map several audio #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cchampet
merged 45 commits into
avTranscoder:develop
from
cchampet:dev_transcoderUseComplexFilterToMapAudio
Jul 21, 2016
Merged
Transcoder: use complex filter to map several audio #271
cchampet
merged 45 commits into
avTranscoder:develop
from
cchampet:dev_transcoderUseComplexFilterToMapAudio
Jul 21, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* To be able to read data from several source, and encode them in the same output stream. * This will be done in the next commits.
The buffer could be different.
* _sourceBuffers to _decodedData. * _frameBuffers to _convertedData.
To have a buffer of filtered data.
* In this case, '_inputStreams.size() == 1' is always true! * Anyway, we should check the '_currentInputStream' attribute because it is used in the method.
* No pointers are needed here. * Updated FilterGraph parameters to launch a process.
…d data Need to define 'Frame::operator='.
Confusing when we will have several input streams.
The VideoFrameDesc could be found from the given frame when decoding.
The AudioFrameDesc could be found from the given frame when decoding.
* Add provate method 'addDecoder'. * Will be used to add several decoders.
* Need pointers here to be able to use polymorphism. * Updated FilterGraph parameters to launch a process. * Almost a revert of commit ecd3ddd
The _currentDecoder could be one of the decoder in the _inputDecoders list.
* Renamed private method 'getProfileFromFile' to 'getProfileFromInput'. * Removed private method 'addTranscodeStream'.
refFrame method allocates new data that will be freed by calling clear method or the destructor of the referenced frame.
Avoid switching if the current case is a generator.
After calling 'avcodec_decode_audio4', sometimes the channel layout of the frame is set to 0. I could be a problem in the next steps of the process.
2 inputs is the default value for this filter.
…he profile as a string
Added vector<InputStreamDesc> in the SWIG interface.
…into dev_transcoderUseComplexFilterToMapAudio Conflicts: test/pyTest/testSetFrame.py
The profile is found from the inputs.
This code was never reach, since the previous intructions already check if the frame is a valid audio frame.
Better to check a more complicated case, when the encoding profile is found from the inputs.
If channel_layout attribute is not indicated, the method returns the default channel layout which corresponds to the given number of channels.
To testAddAStreamFromAFileWhichDoesNotExist
The width and height should be added as string.
* AV_PIX_FMT_NONE = -1 * YUV420P = 0
…puts Added a python test to check this behavior.
…into dev_transcoderUseComplexFilterToMapAudio
Changes Unknown when pulling 2e61259 on cchampet:dev_transcoderUseComplexFilterToMapAudio into * on avTranscoder:develop*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.