Skip to content

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Jan 26, 2025

This reverts commit fbf8bc1 (#2514)

Also, update the CHANGELOG about the reverting.

Fixes #908, which is about the pip-compile not using the right files
for performing the locking. It seems that the pip upgrade regressed
this error.

…g packages (bazel-contrib#2514)

This reverts commit fbf8bc1.

Also, update the CHANGELOG about the reverting.

Fixes bazel-contrib#908.
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update description to mention the problem and why this fixes it. Otherwise LGTM

@aignas aignas enabled auto-merge January 28, 2025 02:51
@aignas aignas added this pull request to the merge queue Jan 28, 2025
Merged via the queue into bazel-contrib:main with commit 309ee59 Jan 28, 2025
4 checks passed
@aignas aignas deleted the revert-2514 branch January 28, 2025 03:44
@aignas aignas mentioned this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile_pip_requirements no longer uses predictable paths
2 participants