Layout fixes #270
Merged
Layout fixes #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frozenskys Looks like there's more that needs fixing. I'm having a look at 480x272 in the sim now. We need to change the text size for both high resolution screens. textSize = 0 |
|
@klutvott123 I'm assuming that would want changed in 320x480 as well ? |
|
@frozenskys Yes that one too. 👍 |
mikeller
previously approved these changes
Oct 23, 2019
b085925 to
07d083a
Compare
|
@mikeller rebased to latest master - do I need to squash? |
|
@frozenskys: Yes please. |
Whitespace fixes Layout fixes for 212x64 Fix high res layouts text size.
07d083a to
64f1112
Compare
|
@mikeller done - and learnt some git in the process :) |
mikeller
approved these changes
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @klutvott123 for pointing out some issues with the layouts for 128x64 (QX7) and 212x64 (X9D) after the refactoring was done. This PR will need to be rebased once #268 and #269 have been merged.