fix(tab): typo aria-lablelledby #1959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed in bootstrap-vue#954 , but apparently somewhere along the way `lib/` was changed to `src/` and the fix was lost. Found the issue because it was affecting my Lighthouse accessibility scores.
Codecov Report
@@ Coverage Diff @@
## dev #1959 +/- ##
=======================================
Coverage 61.26% 61.26%
=======================================
Files 154 154
Lines 2886 2886
Branches 796 796
=======================================
Hits 1768 1768
Misses 802 802
Partials 316 316
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed in #954 , but apparently somewhere along the way
lib/was changed tosrc/and the fix was lost.Found the issue because it was affecting my Lighthouse accessibility scores.