fix(tab): typo aria-lablelledby #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
==========================================
+ Coverage 40% 40.09% +0.09%
==========================================
Files 68 68
Lines 2217 2217
Branches 633 633
==========================================
+ Hits 887 889 +2
+ Misses 1171 1169 -2
Partials 159 159
Continue to review full report at Codecov.
|
alexsasharegan
approved these changes
Aug 30, 2017
costeirs
added a commit
to costeirs/bootstrap-vue
that referenced
this pull request
Jul 23, 2018
This was fixed in bootstrap-vue#954 , but apparently somewhere along the way `lib/` was changed to `src/` and the fix was lost. Found the issue because it was affecting my Lighthouse accessibility scores.
mosinve
pushed a commit
that referenced
this pull request
Jul 24, 2018
This was fixed in #954 , but apparently somewhere along the way `lib/` was changed to `src/` and the fix was lost. Found the issue because it was affecting my Lighthouse accessibility scores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small type for the attribute
:aria-labelledby.