Skip to content

feat(docs): conditionally load babel-standalone only on browsers that need transpilation #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 15, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Dec 15, 2018

Description of Pull Request:

A followup to PR #2286

Only includes babel-standalone for browsers that need to transpile the playground and live examples.

Tests for few basic ES6 syntaxes, and if any fail, then flags that the examples/playground code should be transpiled before instantiating the VMs.

Babel-standalone is still loaded lazily on pages that need it.

Notes:

  • Side effect: Browsers running the transpiler will have more informative playground errors in the console logger.
  • Playground will show a loading message when the compiler is first pulled down (for browsers that need it).
  • Docs will not show a loading message when v-play is downloading the compiler (for browsers that need it).

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #2294 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2294   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files         162      162           
  Lines        3169     3169           
  Branches      879      879           
=======================================
  Hits         2109     2109           
  Misses        779      779           
  Partials      281      281

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6bac5...f843e86. Read the comment docs.

@tmorehouse tmorehouse changed the title feat(docs): conditionalling load babel-standalone only when needed feat(docs): conditionally load babel-standalone only on browsers that need transpilation Dec 15, 2018
@tmorehouse tmorehouse requested a review from pi0 December 15, 2018 02:52
@tmorehouse tmorehouse merged commit 1578732 into dev Dec 15, 2018
@tmorehouse tmorehouse deleted the tmorehouse/docs branch December 15, 2018 04:43
@tmorehouse tmorehouse mentioned this pull request Dec 15, 2018
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant