Skip to content

fix(pagination pagination-nav): v-model active class fix + keypress click fix (Fixes #1985, #1629) #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Dec 16, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Dec 15, 2018

Description of Pull Request:

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Converts computed prop that had side effects to a method.
@tmorehouse tmorehouse changed the title fix(pagination mixin): remove computed prop with side effects fix(pagination mixin): replace computed prop with side effects with method Dec 15, 2018
@tmorehouse tmorehouse requested a review from pi0 December 15, 2018 19:49
@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #2299 into dev will increase coverage by 0.54%.
The diff coverage is 67.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #2299      +/-   ##
=========================================
+ Coverage   66.56%   67.1%   +0.54%     
=========================================
  Files         162     162              
  Lines        3170    3213      +43     
  Branches      880     892      +12     
=========================================
+ Hits         2110    2156      +46     
+ Misses        779     778       -1     
+ Partials      281     279       -2
Impacted Files Coverage Δ
src/components/pagination-nav/pagination-nav.js 78.26% <55.55%> (+3.26%) ⬆️
src/mixins/pagination.js 68.58% <67.24%> (+9.06%) ⬆️
src/components/pagination/pagination.js 50% <87.5%> (+18.75%) ⬆️
src/components/link/link.js 74.07% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8b431...8670d5f. Read the comment docs.

@tmorehouse
Copy link
Member Author

It appears switching to a method creates a watcher/reactive loop.

Need to refactor how pages are generated

@tmorehouse tmorehouse changed the title fix(pagination mixin): replace computed prop with side effects with method fix(pagination mixin): remove side effects from computed prop Dec 16, 2018
@tmorehouse tmorehouse changed the title fix(pagination mixin): remove side effects from computed prop fix(pagination mixin): remove side effects from computed prop + bug fixes Dec 16, 2018
@tmorehouse tmorehouse changed the title fix(pagination mixin): remove side effects from computed prop + bug fixes fix(pagination mixin): remove side effects from computed prop + bug fixes (Fixes #1985) Dec 16, 2018
@tmorehouse tmorehouse changed the title fix(pagination mixin): remove side effects from computed prop + bug fixes (Fixes #1985) fix(pagination mixin): remove side effects from computed prop + bug fixes (Fixes #1985, #1629) Dec 16, 2018
@tmorehouse tmorehouse changed the title fix(pagination mixin): remove side effects from computed prop + bug fixes (Fixes #1985, #1629) fix(pagination mixin): remove side effects from computed prop + bug fixes (Fixes #1985, #1891, #1629) Dec 16, 2018
@tmorehouse tmorehouse changed the title fix(pagination mixin): remove side effects from computed prop + bug fixes (Fixes #1985, #1891, #1629) fix(pagination mixin): remove side effects from computed prop + bug fixes (Fixes #1985, #1629) Dec 16, 2018
@tmorehouse tmorehouse changed the title fix(pagination mixin): remove side effects from computed prop + bug fixes (Fixes #1985, #1629) fix(pagination mixin): v-model active class fix + keypress click fix (Fixes #1985, #1629) Dec 16, 2018
@tmorehouse tmorehouse changed the title fix(pagination mixin): v-model active class fix + keypress click fix (Fixes #1985, #1629) fix(pagination pagination-nav): v-model active class fix + keypress click fix (Fixes #1985, #1629) Dec 16, 2018
@tmorehouse tmorehouse mentioned this pull request Dec 16, 2018
89 tasks
@tmorehouse tmorehouse merged commit 9afba6c into dev Dec 16, 2018
@tmorehouse tmorehouse deleted the tmorehouse/pagination branch December 16, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant