-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(pagination pagination-nav): v-model active class fix + keypress click fix (Fixes #1985, #1629) #2299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Converts computed prop that had side effects to a method.
Codecov Report
@@ Coverage Diff @@
## dev #2299 +/- ##
=========================================
+ Coverage 66.56% 67.1% +0.54%
=========================================
Files 162 162
Lines 3170 3213 +43
Branches 880 892 +12
=========================================
+ Hits 2110 2156 +46
+ Misses 779 778 -1
+ Partials 281 279 -2
Continue to review full report at Codecov.
|
It appears switching to a method creates a watcher/reactive loop. Need to refactor how pages are generated |
Description of Pull Request:
pagination-nav
when clicked, emulating normal link navigation behavior (Closes: Keyboard Navigation for Pagination Nav breaks when going to buttons not on initial render. #1891)b-pagination-nav
(Addresses Keyboard Navigation for Pagination Nav breaks when going to buttons not on initial render. #1891 (comment))PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes: