Skip to content

fix(table): fix broken aria-labels for sortable columns + break out code into additional mixins + tests #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 161 commits into from
Mar 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
161 commits
Select commit Hold shift + click to select a range
4d1bc61
Create pagination-mixin.js
tmorehouse Mar 20, 2019
9aa4e55
Rename pagination-mixin.js to mixin-pagination.js
tmorehouse Mar 20, 2019
8aa7833
Create mixin-sorting.js
tmorehouse Mar 20, 2019
04766fa
Update mixin-sorting.js
tmorehouse Mar 20, 2019
d866873
Create mixin-filter.js
tmorehouse Mar 20, 2019
bd50e28
Update mixin-filter.js
tmorehouse Mar 20, 2019
927424d
Update mixin-filter.js
tmorehouse Mar 20, 2019
b578825
Update mixin-filter.js
tmorehouse Mar 20, 2019
2175d0d
Create mixins-items.js
tmorehouse Mar 20, 2019
0352116
Update and rename mixins-items.js to mixin-items.js
tmorehouse Mar 20, 2019
222a386
Rename mixin-filter.js to mixin-filtering.js
tmorehouse Mar 20, 2019
262fd4c
Update table.js
tmorehouse Mar 20, 2019
c12bced
Update table.js
tmorehouse Mar 20, 2019
b3ea883
Update mixin-items.js
tmorehouse Mar 20, 2019
4557f38
Update mixin-provider.js
tmorehouse Mar 20, 2019
43d7a17
Update table.js
tmorehouse Mar 20, 2019
0f3ed4d
Create table-filtering.spec.js
tmorehouse Mar 20, 2019
fb59b71
Update table-filtering.spec.js
tmorehouse Mar 20, 2019
c69d50e
Update table-filtering.spec.js
tmorehouse Mar 20, 2019
6d14f1b
Update table-filtering.spec.js
tmorehouse Mar 20, 2019
eadf5e6
Update table-filtering.spec.js
tmorehouse Mar 20, 2019
f7a83f1
Update table-filtering.spec.js
tmorehouse Mar 20, 2019
5219fc5
Update mixin-filtering.js
tmorehouse Mar 20, 2019
759da32
Update mixin-filtering.js
tmorehouse Mar 20, 2019
ac76042
Update table-filtering.spec.js
tmorehouse Mar 20, 2019
7a7ef98
Update table-bottom-row.spec.js
tmorehouse Mar 20, 2019
a957261
Update table-busy.spec.js
tmorehouse Mar 20, 2019
ec6b9d8
Update mixin-filtering.js
tmorehouse Mar 20, 2019
6749fa1
Update table-filtering.spec.js
tmorehouse Mar 20, 2019
220baad
Update table-filtering.spec.js
tmorehouse Mar 20, 2019
c80a111
Update mixin-filtering.js
tmorehouse Mar 20, 2019
1f6f28c
Update table.js
tmorehouse Mar 20, 2019
abd15a2
Update table.js
tmorehouse Mar 20, 2019
82e685d
Update mixin-items.js
tmorehouse Mar 20, 2019
b440194
Update table.js
tmorehouse Mar 20, 2019
9aefd8f
Update table.js
tmorehouse Mar 20, 2019
9fdb813
Update mixin-thead.js
tmorehouse Mar 20, 2019
aa770d1
Update mixin-thead.js
tmorehouse Mar 20, 2019
efb11db
Update mixin-thead.js
tmorehouse Mar 21, 2019
d40f33c
Update mixin-sorting.js
tmorehouse Mar 21, 2019
c21a229
Update mixin-sorting.js
tmorehouse Mar 21, 2019
35a9d33
Update mixin-thead.js
tmorehouse Mar 21, 2019
43eb470
Update table.spec.js
tmorehouse Mar 21, 2019
4985f03
Update table-thead-events.spec.js
tmorehouse Mar 21, 2019
ac1dea5
Update table-tfoot-events.spec.js
tmorehouse Mar 21, 2019
e45966c
Update table-thead-events.spec.js
tmorehouse Mar 21, 2019
faa9f8b
Update table-thead-events.spec.js
tmorehouse Mar 21, 2019
f388606
Update mixin-sorting.js
tmorehouse Mar 21, 2019
64b2cd7
Update mixin-sorting.js
tmorehouse Mar 21, 2019
8bf74a2
Update table-sort.spec.js
tmorehouse Mar 21, 2019
a395bae
Update table-sort.spec.js
tmorehouse Mar 21, 2019
fa75c11
Update table-sort.spec.js
tmorehouse Mar 21, 2019
cea5ff3
Update mixin-sorting.js
tmorehouse Mar 21, 2019
8340577
Update mixin-sorting.js
tmorehouse Mar 21, 2019
06ba8b7
Update mixin-sorting.js
tmorehouse Mar 21, 2019
6206ae8
Update table.spec.js
tmorehouse Mar 21, 2019
bd8e61d
Update table.spec.js
tmorehouse Mar 21, 2019
27797f1
Update and rename table-sort.spec.js to table-sorting.spec.js
tmorehouse Mar 21, 2019
952fce4
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
b6b419b
Update table.spec.js
tmorehouse Mar 21, 2019
e8d2fed
Update README.md
tmorehouse Mar 21, 2019
52eb8e0
Update table.spec.js
tmorehouse Mar 21, 2019
5783cef
Update utils.js
tmorehouse Mar 21, 2019
679b751
Update utils.js
tmorehouse Mar 21, 2019
e7b6a47
Update mixin-items.js
tmorehouse Mar 21, 2019
bc6ec25
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
92b737b
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
deb7424
Update mixin-sorting.js
tmorehouse Mar 21, 2019
b438231
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
243803f
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
0e7665c
Update mixin-sorting.js
tmorehouse Mar 21, 2019
030a4d1
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
372ee9b
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
f5c3dec
Update table-provider.spec.js
tmorehouse Mar 21, 2019
1b4473a
Update table-row-details.spec.js
tmorehouse Mar 21, 2019
cc4343c
Update table-row-details.spec.js
tmorehouse Mar 21, 2019
4e63aae
Update table-row-details.spec.js
tmorehouse Mar 21, 2019
63b64f7
Update mixin-empty.js
tmorehouse Mar 21, 2019
617d21c
Update table-filtering.spec.js
tmorehouse Mar 21, 2019
2beab5a
Update table-filtering.spec.js
tmorehouse Mar 21, 2019
b4d8468
Update table-filtering.spec.js
tmorehouse Mar 21, 2019
00782ae
Update table.spec.js
tmorehouse Mar 21, 2019
507c06a
Update mixin-filtering.js
tmorehouse Mar 21, 2019
2a633ad
Update table-provider.spec.js
tmorehouse Mar 21, 2019
2b617db
Update table-row-details.spec.js
tmorehouse Mar 21, 2019
dbfa04d
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
ec9bdad
Update table-tfoot-events.spec.js
tmorehouse Mar 21, 2019
b0cbb1a
Update table-thead-events.spec.js
tmorehouse Mar 21, 2019
e60afce
Update table-busy.spec.js
tmorehouse Mar 21, 2019
859275a
Update table-caption.spec.js
tmorehouse Mar 21, 2019
7abade7
Update table-colgroup.spec.js
tmorehouse Mar 21, 2019
50ec49c
Update table-primarykey.spec.js
tmorehouse Mar 21, 2019
ae87ae5
Update table-selectable.spec.js
tmorehouse Mar 21, 2019
a0a5517
Update table-tbody-row-events.spec.js
tmorehouse Mar 21, 2019
9ecec77
Update table-tbody-transition.spec.js
tmorehouse Mar 21, 2019
175cfac
Update table-thead-top.spec.js
tmorehouse Mar 21, 2019
9c6aee9
Update table-top-row.spec.js
tmorehouse Mar 21, 2019
25937bb
Update and rename table-bottom-row.spec.js to table-tbody-bottom-row.…
tmorehouse Mar 21, 2019
29e78ba
Rename table-top-row.spec.js to table-tbody-top-row.spec.js
tmorehouse Mar 21, 2019
9abb2dc
Create table-pagination.spec.js
tmorehouse Mar 21, 2019
e2302bb
Update table-pagination.spec.js
tmorehouse Mar 21, 2019
1f3caa7
Update table-pagination.spec.js
tmorehouse Mar 21, 2019
509603d
Update table-pagination.spec.js
tmorehouse Mar 21, 2019
fc64a0e
Update table.spec.js
tmorehouse Mar 21, 2019
5c389ea
Update form-select.spec.js
tmorehouse Mar 21, 2019
5ec70ad
Update pagination.spec.js
tmorehouse Mar 21, 2019
21d834e
Rename table.spec.js to table.old.spec.js
tmorehouse Mar 21, 2019
cdb31dc
Create table.spec.js
tmorehouse Mar 21, 2019
756add9
Update table.spec.js
tmorehouse Mar 21, 2019
1003961
Update table.spec.js
tmorehouse Mar 21, 2019
b1ec6b3
Update table.old.spec.js
tmorehouse Mar 21, 2019
e629ea3
Update table.spec.js
tmorehouse Mar 21, 2019
53bc416
Update table.spec.js
tmorehouse Mar 21, 2019
3516d26
Update table.spec.js
tmorehouse Mar 21, 2019
10694c2
Update table.old.spec.js
tmorehouse Mar 21, 2019
264fe07
Update table.old.spec.js
tmorehouse Mar 21, 2019
8f8dd7c
Update table.spec.js
tmorehouse Mar 21, 2019
1d50516
Update table.spec.js
tmorehouse Mar 21, 2019
e8c2c40
Update table.spec.js
tmorehouse Mar 21, 2019
5ca5163
Update table.spec.js
tmorehouse Mar 21, 2019
ceb7e2b
Update table.old.spec.js
tmorehouse Mar 21, 2019
771c712
Update table.html
tmorehouse Mar 21, 2019
651f1ea
Create startcase.spec.js
tmorehouse Mar 21, 2019
7ad6f5e
Update table.spec.js
tmorehouse Mar 21, 2019
b7baa0f
Update table.spec.js
tmorehouse Mar 21, 2019
935806b
Update table.spec.js
tmorehouse Mar 21, 2019
4225a5b
Update table.spec.js
tmorehouse Mar 21, 2019
31087c5
Update table.old.spec.js
tmorehouse Mar 21, 2019
dd0042a
Update mixin-thead.js
tmorehouse Mar 21, 2019
b55acc8
Update table.spec.js
tmorehouse Mar 21, 2019
f5a02e2
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
2c6d7e6
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
e6a8b33
Update table.old.spec.js
tmorehouse Mar 21, 2019
e521494
Update table.html
tmorehouse Mar 21, 2019
6208aab
Update table-sorting.spec.js
tmorehouse Mar 21, 2019
64b8b08
Update table.old.spec.js
tmorehouse Mar 21, 2019
c8d4dfc
Update table.html
tmorehouse Mar 21, 2019
4aab83b
Update table.old.spec.js
tmorehouse Mar 21, 2019
e0086bd
Delete table.old.spec.js
tmorehouse Mar 21, 2019
a602893
Update table.spec.js
tmorehouse Mar 21, 2019
0cf495d
Update table.spec.js
tmorehouse Mar 21, 2019
a0b467f
Update table.spec.js
tmorehouse Mar 21, 2019
201e05d
Update table.spec.js
tmorehouse Mar 21, 2019
41aeff6
Update table.spec.js
tmorehouse Mar 21, 2019
8b3af57
Update table.spec.js
tmorehouse Mar 21, 2019
2703c1d
Update mixin-tbody-row.js
tmorehouse Mar 21, 2019
d576038
Update table.spec.js
tmorehouse Mar 21, 2019
21c59d8
Update table.spec.js
tmorehouse Mar 21, 2019
c2b9c94
Delete table.html
tmorehouse Mar 21, 2019
2b84c15
Delete table.js
tmorehouse Mar 21, 2019
15ca18d
Update table.spec.js
tmorehouse Mar 21, 2019
dae0ff8
Update table.spec.js
tmorehouse Mar 21, 2019
c43871a
Update table.spec.js
tmorehouse Mar 21, 2019
41237c3
Merge branch 'dev' into tmorehouse/table-more
tmorehouse Mar 21, 2019
2ddc794
Merge branch 'dev' into tmorehouse/table-more
jacobmllr95 Mar 21, 2019
60934fb
Update README.md
tmorehouse Mar 22, 2019
1dbcb4a
Update table.spec.js
tmorehouse Mar 22, 2019
44600bf
Update mixin-tbody-row.js
tmorehouse Mar 22, 2019
209815c
Update table.spec.js
tmorehouse Mar 22, 2019
8ee3185
Update mixin-sorting.js
tmorehouse Mar 22, 2019
f9aea01
Update table.spec.js
tmorehouse Mar 22, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/components/form-select/form-select.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,35 @@ describe('form-select', () => {
wrapper.destroy()
})

it('updating v-model (value) when selects correct option', async () => {
const wrapper = mount(Select, {
propsData: {
options: ['one', 'two', { text: 'three', value: { three: 3 } }],
value: 'one'
}
})
const $options = wrapper.findAll('option')
expect($options.length).toBe(3)

expect($options.at(0).element.selected).toBe(true)

// select 2nd option
wrapper.setProps({
value: 'two'
})

expect($options.at(1).element.selected).toBe(true)

// select 3rd option
wrapper.setProps({
value: { three: 3 }
})

expect($options.at(2).element.selected).toBe(true)

wrapper.destroy()
})

it('updates v-model when option selected in single mode with complex values', async () => {
const wrapper = mount(Select, {
propsData: {
Expand Down
29 changes: 29 additions & 0 deletions src/components/pagination/pagination.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,35 @@ describe('pagination', () => {
wrapper.destroy()
})

it('renders corerct number of elements when total-rows changes', async () => {
const wrapper = mount(Pagination, {
propsData: {
size: 'sm',
totalRows: 1,
perPage: 1,
limit: 10
}
})
expect(wrapper.is('ul')).toBe(true)
expect(wrapper.findAll('li').length).toBe(5)

wrapper.setProps({
totalRows: 4
})

expect(wrapper.is('ul')).toBe(true)
expect(wrapper.findAll('li').length).toBe(8)

wrapper.setProps({
perPage: 2
})

expect(wrapper.is('ul')).toBe(true)
expect(wrapper.findAll('li').length).toBe(6)

wrapper.destroy()
})

it('has class "pagination-sm" when prop size="sm"', async () => {
const wrapper = mount(Pagination, {
propsData: {
Expand Down
191 changes: 105 additions & 86 deletions src/components/table/README.md

Large diffs are not rendered by default.

148 changes: 0 additions & 148 deletions src/components/table/fixtures/table.html

This file was deleted.

175 changes: 0 additions & 175 deletions src/components/table/fixtures/table.js

This file was deleted.

Loading