Skip to content

fix(collapse/toggle): persist toggle state on element and prevent multiple state emits (closes #2923) #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 27, 2019

Description of Pull Request:

Closes #2923

Better approach to fixing the original issue #1798 (and PR #2102)

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #2924 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2924      +/-   ##
==========================================
+ Coverage   91.03%   91.04%   +<.01%     
==========================================
  Files         205      205              
  Lines        3290     3293       +3     
  Branches      996      996              
==========================================
+ Hits         2995     2998       +3     
  Misses        213      213              
  Partials       82       82
Impacted Files Coverage Δ
src/components/collapse/collapse.js 81.35% <ø> (-0.32%) ⬇️
src/directives/toggle/toggle.js 95.83% <100%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b1710...3330a28. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review March 27, 2019 13:58
@tmorehouse tmorehouse merged commit 6f899fc into dev Mar 27, 2019
@tmorehouse tmorehouse deleted the tmorehouse/collapse-toggle branch March 27, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 events fired on collapse event
1 participant