-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(modal): stacked modal z-index calculations (closes #3015) #3017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3017 +/- ##
=========================================
+ Coverage 98.22% 98.63% +0.4%
=========================================
Files 205 206 +1
Lines 3719 3731 +12
Branches 1120 1120
=========================================
+ Hits 3653 3680 +27
+ Misses 46 37 -9
+ Partials 20 14 -6
Continue to review full report at Codecov.
|
tmorehouse
reviewed
Apr 5, 2019
tmorehouse
reviewed
Apr 5, 2019
This comment has been minimized.
This comment has been minimized.
18 tasks
This comment has been minimized.
This comment has been minimized.
zindexOffset
configurable in config and lower default (closes #3015)
tmorehouse
approved these changes
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
This PR makes the
z-index
offset used for stacked modals from2000
to1040
which is the default from Boostrap for the modal backdrop.Automatically detects if the modal backdrop z-index has been changed from the default.
Now uses an increment value of 1 for each successively opened stacked modal, rather than using the previous value of 2000.
Introduced a helper module to handle keeping track of stacked modals (and their display order), which includes adjusting their z-index values as modals are opened and closed, as well as handles any adjustments needed to the document body and it's contents.
Closes #3015.
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)and adding a new feature, break them into separate PRs if at all possible.
Conventional Commits naming convention (i.e.
"fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
"chore: fix typo in docs", etc). This is very important, as the
CHANGELOG
is generatedfrom these messages.
If new features/enhancement/fixes are added or changed:
package.json
for slot andevent changes)
keyboard only users? clickable items should be in the tab index, etc)
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:
suggestion issue first and wait for approval before working on it)