Skip to content

fix(modal): stacked modal z-index calculations (closes #3015) #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 7, 2019

Conversation

jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented Apr 5, 2019

Description of Pull Request:

This PR makes the z-index offset used for stacked modals from 2000 to 1040 which is the default from Boostrap for the modal backdrop.

Automatically detects if the modal backdrop z-index has been changed from the default.

Now uses an increment value of 1 for each successively opened stacked modal, rather than using the previous value of 2000.

Introduced a helper module to handle keeping track of stacked modals (and their display order), which includes adjusting their z-index values as modals are opened and closed, as well as handles any adjustments needed to the document body and it's contents.

Closes #3015.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #3017 into dev will increase coverage by 0.4%.
The diff coverage is 99.04%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #3017     +/-   ##
=========================================
+ Coverage   98.22%   98.63%   +0.4%     
=========================================
  Files         205      206      +1     
  Lines        3719     3731     +12     
  Branches     1120     1120             
=========================================
+ Hits         3653     3680     +27     
+ Misses         46       37      -9     
+ Partials       20       14      -6
Impacted Files Coverage Δ
src/utils/dom.js 100% <100%> (ø) ⬆️
src/mixins/listen-on-root.js 100% <100%> (ø) ⬆️
src/components/modal/helpers/modal-manager.js 100% <100%> (ø)
src/components/modal/modal.js 91.3% <95.83%> (+3.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d903008...adbfa50. Read the comment docs.

@jacobmllr95 jacobmllr95 requested a review from tmorehouse April 5, 2019 09:05
@tmorehouse

This comment has been minimized.

@tmorehouse

This comment has been minimized.

@tmorehouse tmorehouse changed the title fix(modal): make zindexOffset configurable in config and lower default (closes #3015) fix(modal): stacked modal z-index calculations (closes #3015) Apr 6, 2019
@tmorehouse tmorehouse marked this pull request as ready for review April 7, 2019 00:11
@tmorehouse tmorehouse merged commit 891e8cc into dev Apr 7, 2019
@tmorehouse tmorehouse deleted the fix-modal-zindex-configurable branch April 7, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Z-index of Modal
2 participants