Skip to content

fix(modal): z-index adjustments in PR #3017 #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 5, 2019

Description of Pull Request:

Some additional modifications/tweaks to be applied to PR #3017

  • No longer needs config options to set z-index (determined automatically by querying the computed styles of a temporary modal-backdrop element)
  • Each stacked modal will now have it's z-index offset by 1 from the previously opened modal, keeping all z-indexes within a small range (i.e. 1040, 1041, 1042, etc), which should avoid placing modals over such items as notifications and toasts (which typically have a z-index of 2000 or higher)
  • Created a modalManager instance that will handle keeping track of the opened modals (and their order), and managing their z-index, as well as controlling classes and adjustments on document.body and sticky/fixed page content.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse changed the title fix(modal): use z-index of 0 for first opened modal experiment(modal): use z-index of 0 for first opened modal Apr 5, 2019
@tmorehouse tmorehouse changed the title experiment(modal): use z-index of 0 for first opened modal experiment(modal): z-index adjustments Apr 5, 2019
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #3023 into fix-modal-zindex-configurable will increase coverage by 0.13%.
The diff coverage is 99.02%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           fix-modal-zindex-configurable    #3023      +/-   ##
=================================================================
+ Coverage                          98.48%   98.62%   +0.13%     
=================================================================
  Files                                205      206       +1     
  Lines                               3687     3698      +11     
  Branches                            1104     1105       +1     
=================================================================
+ Hits                                3631     3647      +16     
+ Misses                                41       37       -4     
+ Partials                              15       14       -1
Impacted Files Coverage Δ
src/utils/dom.js 100% <ø> (ø) ⬆️
src/utils/config.js 100% <ø> (ø) ⬆️
src/mixins/listen-on-root.js 100% <100%> (ø) ⬆️
src/components/modal/helpers/modal-manager.js 100% <100%> (ø)
src/components/modal/modal.js 91.25% <95.83%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea82a2...10a40eb. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review April 6, 2019 00:09
@tmorehouse tmorehouse changed the title experiment(modal): z-index adjustments fix(modal): z-index adjustments Apr 6, 2019
@tmorehouse tmorehouse requested a review from jacobmllr95 April 6, 2019 00:57
@tmorehouse tmorehouse changed the title fix(modal): z-index adjustments fix(modal): z-index adjustments in PR #3017 Apr 6, 2019
@tmorehouse tmorehouse merged commit 00a9fbb into fix-modal-zindex-configurable Apr 7, 2019
@tmorehouse tmorehouse deleted the tmorehouse/modal-z-index-zero branch April 7, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant