Skip to content

feat: modal manager helper for modal z-index control #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Apr 6, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 6, 2019

Work In Progress

Modal Manager helper to control the stacked modal's z-indexes as well as controlling the body adjustments needed when a single modal first opens, and when no modals are left open.

To be applied to the newer z-index PR #3023

@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #3027 into tmorehouse/modal-z-index-zero will increase coverage by 0.13%.
The diff coverage is 98.94%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           tmorehouse/modal-z-index-zero    #3027      +/-   ##
=================================================================
+ Coverage                          98.48%   98.62%   +0.13%     
=================================================================
  Files                                205      206       +1     
  Lines                               3695     3698       +3     
  Branches                            1105     1105              
=================================================================
+ Hits                                3639     3647       +8     
+ Misses                                41       37       -4     
+ Partials                              15       14       -1
Impacted Files Coverage Δ
src/utils/dom.js 100% <ø> (ø) ⬆️
src/mixins/listen-on-root.js 100% <100%> (ø) ⬆️
src/components/modal/helpers/modal-manager.js 100% <100%> (ø)
src/components/modal/modal.js 91.25% <93.75%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e729e...ef041c7. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review April 6, 2019 23:49
@tmorehouse tmorehouse merged commit 10a40eb into tmorehouse/modal-z-index-zero Apr 6, 2019
@tmorehouse tmorehouse deleted the tmorehouse/modal-manager branch April 6, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant