-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: modal manager helper for modal z-index control #3027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tmorehouse
merged 44 commits into
tmorehouse/modal-z-index-zero
from
tmorehouse/modal-manager
Apr 6, 2019
Merged
feat: modal manager helper for modal z-index control #3027
tmorehouse
merged 44 commits into
tmorehouse/modal-z-index-zero
from
tmorehouse/modal-manager
Apr 6, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tmorehouse/modal-z-index-zero #3027 +/- ##
=================================================================
+ Coverage 98.48% 98.62% +0.13%
=================================================================
Files 205 206 +1
Lines 3695 3698 +3
Branches 1105 1105
=================================================================
+ Hits 3639 3647 +8
+ Misses 41 37 -4
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
…/modal/helpers/modal-manager.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress
Modal Manager helper to control the stacked modal's z-indexes as well as controlling the body adjustments needed when a single modal first opens, and when no modals are left open.
To be applied to the newer z-index PR #3023