[navs][dropdown] Additional ARIA features #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync with Master
[modal] focusFirst timing tweak (#357)
Adds role="navigation" when the b-nav is not inside a b-navbar
Whenever the show state changes, the 'event collapse::toggle::state' (with args id and state) is emitted on $root. This event Used for setting aria states on controlling trigger element aria-expanded attribute is set based on current state.
Listens for state changes from collapse ('collapse::toggle::state') to set toggle aria atributes
Removed dependency on generate-id aria-labelledby attributes only present if ID is provided
pi0
reviewed
May 8, 2017
lib/components/collapse.vue
Outdated
| created() { | ||
| this.$root.$on('collapse::toggle', target => { | ||
| if (target !== this.id) { | ||
| return; | ||
| } | ||
| this.toggle(); | ||
| }); | ||
| this.emitState(); |
There was a problem hiding this comment.
We are emitting in mounted. So why this is needed ?
There was a problem hiding this comment.
Just in case the receiving components that are already in document need to reflect the state (although it does default to false).
There was a problem hiding this comment.
Although, since the toggle state does default to false, it can probably be removed from create() and left on mount()
|
Hmmm Not sure where this error is originating from. |
pi0
reviewed
May 8, 2017
lib/components/dropdown.vue
Outdated
| @@ -30,7 +31,7 @@ | |||
| <div :class="['dropdown-menu',{'dropdown-menu-right': right}]" | |||
| ref="menu" | |||
| role="menu" | |||
| :aria-labelledby="split ? null : _id" | |||
| :aria-labelledby="id ? (id + (split ? '__BV_toggle_' : '__BV_button_')) : null)" | |||
There was a problem hiding this comment.
I am think this might be where it is, although I have looked at it 20 times and don't see any typos.
Maybe if I move this to a computed property
There was a problem hiding this comment.
:D Look and extra closing parentheses (after null)
|
Removed that pesky closing bracket |
33 tasks
valexiev
added a commit
to valexiev/bootstrap-vue
that referenced
this pull request
May 9, 2017
* upstream/master: (220 commits) [button-toolbar] docs (bootstrap-vue#368) ESLint New component b-button-toolbar (bootstrap-vue#367) [link] fix click event [docs] navbar styling Refactor link mixin [button-group] fix toolbar keynav (bootstrap-vue#366) [Docs] ScrollSpy directive JSFiddle [Link] Small fixes [link] Allow both router links and regular links to co-exist in same document (bootstrap-vue#365) [pagination] ARIA attributes + Keyboard navigation (bootstrap-vue#364) [dropdown-item] explicit component reference (bootstrap-vue#361) Additional ARIA on navs and dropdown (bootstrap-vue#358) ESLint [docs] ScrollSpy [scrollspy] SSR fix v0.15.6 [modal] focusFirst timing tweak (bootstrap-vue#357) [scrollspy] documentation update [scrollspy] Documentation (bootstrap-vue#356) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional/better ARIA attributes (addresses some of #333)
Also removed dependency on generate-id