[button-toolbar] New component b-button-toolbar #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I remove the keyboard navigation and toolbar option from b-button-group? or leave it in for now as deprecated? |
|
I think so. As button-group is just a helper for styling. Also it would be great if you can provide some docs. (Simply copy paste docs/components/button-group as a starting point) |
|
Will do. I'll remove the toolbar option from the |
Moved to new button-toolbar wrapper component
|
I've removed the toolbar features of |
33 tasks
valexiev
added a commit
to valexiev/bootstrap-vue
that referenced
this pull request
May 9, 2017
* upstream/master: (220 commits) [button-toolbar] docs (bootstrap-vue#368) ESLint New component b-button-toolbar (bootstrap-vue#367) [link] fix click event [docs] navbar styling Refactor link mixin [button-group] fix toolbar keynav (bootstrap-vue#366) [Docs] ScrollSpy directive JSFiddle [Link] Small fixes [link] Allow both router links and regular links to co-exist in same document (bootstrap-vue#365) [pagination] ARIA attributes + Keyboard navigation (bootstrap-vue#364) [dropdown-item] explicit component reference (bootstrap-vue#361) Additional ARIA on navs and dropdown (bootstrap-vue#358) ESLint [docs] ScrollSpy [scrollspy] SSR fix v0.15.6 [modal] focusFirst timing tweak (bootstrap-vue#357) [scrollspy] documentation update [scrollspy] Documentation (bootstrap-vue#356) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper component for creating toolbars comprised of button-groups and/or input-groups.
Direct children elements should be
b-button-groupandb-input-groupcomponents.Allows for optional keyboard navigation by setting prop
keyNavtotrue(defaults tofalse)