bootstrap-vue · jacobmllr95 · Feb 13, 2020 · Feb 13, 2020 · Feb 13, 2020 · Feb 13, 2020
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -14,6 +14,14 @@ module.exports = {
     Vue: true
   },
   rules: {
+    'no-unused-vars': [
+      'error',
+      {
+        vars: 'all',
+        args: 'after-used',
+        ignoreRestSiblings: false
+      }
+    ],
     'spaced-comment': 'off', // needed to ignore `/*#__PURE__*/` comments
     'vue/html-self-closing': [
       'error',

diff --git a/docs/common-props.json b/docs/common-props.json
@@ -126,7 +126,7 @@
     "description": "Sets the 'placeholder' attribute value on the form control"
   },
   "readonly": {
-    "description": "Sets the 'readonly' attribute on hte form control"
+    "description": "Sets the 'readonly' attribute on the form control"
   },
   "plaintext": {
     "description": "Set the form control as readonly and renders the control to look like plain text (no borders)"

diff --git a/docs/markdown/reference/images/README.md b/docs/markdown/reference/images/README.md
@@ -97,7 +97,7 @@ In your `nuxt.config.js` file, add the following to your build section:
 ```js
 module.exports = {
   build: {
-    extend(config, ctx) {
+    extend(config) {
       const vueLoader = config.module.rules.find(rule => rule.loader === 'vue-loader')
       vueLoader.options.transformAssetUrls = {
         video: ['src', 'poster'],

diff --git a/docs/nuxt.config.js b/docs/nuxt.config.js
@@ -99,7 +99,7 @@ renderer.blockquote = function(text) {
 
 // Bootstrap v4 table support for markdown renderer
 const originalTable = renderer.table
-renderer.table = function(header, body) {
+renderer.table = function() {
   let table = originalTable.apply(this, arguments)
   table = table
     .replace('<table>', '<table class="b-table table table-bordered table-striped bv-docs-table">')

diff --git a/docs/pages/play.vue b/docs/pages/play.vue
@@ -597,15 +597,15 @@ export default {
         // appData watcher
         this.contentUnWatch = this.$watch(
           'appData',
-          (newVal, oldVal) => {
+          () => {
             this.run()
           },
           { deep: true }
         )
         // Javascript watcher
         this.jsUnWatch = this.$watch(
           () => this.js.trim(),
-          (newVal, oldVal) => {
+          () => {
             this.compileJs()
           },
           { immediate: true }

diff --git a/docs/plugins/play.js b/docs/plugins/play.js
@@ -86,7 +86,7 @@ const destroyVM = (name, vm) => {
   ;[...document.querySelectorAll(`.vue-example-${name}`)].forEach(removeNode)
 }
 
-const processExamples = (el, binding, vnode, oldVnode) => {
+const processExamples = (el, binding, vnode) => {
   if (vnode.context.$options.beforeDestroy) {
     vnode.context.$options.beforeDestroy = []
       .concat(vnode.context.$options.beforeDestroy)

diff --git a/docs/utils/index.js b/docs/utils/index.js
@@ -113,7 +113,7 @@ export const makeTOC = (readme, meta = null) => {
     // Filter out un-matched values
     .filter(v => Array.isArray(v))
     // Create TOC structure
-    .forEach(([value, tag, id, content]) => {
+    .forEach(([, tag, id, content]) => {
       const href = `#${stripQuotes(id)}`
       const label = stripHTML(content)
       if (tag === 'h2') {

diff --git a/nuxt/index.js b/nuxt/index.js
@@ -92,7 +92,7 @@ module.exports = function nuxtBootstrapVue(moduleOptions = {}) {
     if (!usePretranspiled) {
       // Use bootstrap-vue source code for smaller prod builds
       // by aliasing 'bootstrap-vue' to the source files
-      this.extendBuild((config, { isServer }) => {
+      this.extendBuild(config => {
         if (!config.resolve.alias) {
           config.resolve.alias = {}
         }

diff --git a/scripts/postcss.config.js b/scripts/postcss.config.js
@@ -1,4 +1,4 @@
-module.exports = ctx => ({
+module.exports = () => ({
   map: {
     inline: false,
     annotation: true,

diff --git a/src/components/button-toolbar/button-toolbar.js b/src/components/button-toolbar/button-toolbar.js
@@ -61,7 +61,7 @@ export const BButtonToolbar = /*#__PURE__*/ Vue.extend({
     setItemFocus(item) {
       item && item.focus && item.focus()
     },
-    focusFirst(evt) {
+    focusFirst() {
       const items = this.getItems()
       this.setItemFocus(items[0])
     },
@@ -81,7 +81,7 @@ export const BButtonToolbar = /*#__PURE__*/ Vue.extend({
         this.setItemFocus(items[0])
       }
     },
-    focusLast(evt) {
+    focusLast() {
       const items = this.getItems().reverse()
       this.setItemFocus(items[0])
     },

diff --git a/src/components/button-toolbar/button-toolbar.spec.js b/src/components/button-toolbar/button-toolbar.spec.js
@@ -85,12 +85,9 @@ describe('button-toolbar', () => {
     const App = Vue.extend({
       render(h) {
         return h(BButtonToolbar, { props: { keyNav: true } }, [
-          h(BButtonGroup, {}, [h(BButton, {}, 'a'), h(BButton, {}, 'b')]),
-          h(BButtonGroup, {}, [
-            h(BButton, { props: { disabled: true } }, 'c'),
-            h(BButton, {}, 'd')
-          ]),
-          h(BButtonGroup, {}, [h(BButton, {}, 'e'), h(BButton, {}, 'f')])
+          h(BButtonGroup, [h(BButton, 'a'), h(BButton, 'b')]),
+          h(BButtonGroup, [h(BButton, { props: { disabled: true } }, 'c'), h(BButton, 'd')]),
+          h(BButtonGroup, [h(BButton, 'e'), h(BButton, 'f')])
         ])
       }
     })

diff --git a/src/components/button/button-close.js b/src/components/button/button-close.js
@@ -30,7 +30,7 @@ export const BButtonClose = /*#__PURE__*/ Vue.extend({
   name: NAME,
   functional: true,
   props,
-  render(h, { props, data, listeners, slots, scopedSlots }) {
+  render(h, { props, data, slots, scopedSlots }) {
     const $slots = slots()
     const $scopedSlots = scopedSlots || {}
 

diff --git a/src/components/button/button.spec.js b/src/components/button/button.spec.js
@@ -208,7 +208,7 @@ describe('button', () => {
         disabled: true
       },
       listeners: {
-        click: e => {
+        click: () => {
           called++
         }
       }

diff --git a/src/components/carousel/carousel.js b/src/components/carousel/carousel.js
@@ -3,16 +3,9 @@ import KeyCodes from '../../utils/key-codes'
 import noop from '../../utils/noop'
 import observeDom from '../../utils/observe-dom'
 import { getComponentConfig } from '../../utils/config'
-import {
-  selectAll,
-  reflow,
-  addClass,
-  removeClass,
-  setAttr,
-  eventOn,
-  eventOff
-} from '../../utils/dom'
+import { selectAll, reflow, addClass, removeClass, setAttr } from '../../utils/dom'
 import { isBrowser, hasTouchSupport, hasPointerEventSupport } from '../../utils/env'
+import { EVENT_OPTIONS_NO_CAPTURE, eventOn, eventOff } from '../../utils/events'
 import { isUndefined } from '../../utils/inspect'
 import { toInteger } from '../../utils/number'
 import idMixin from '../../mixins/id'
@@ -55,8 +48,6 @@ const TransitionEndEvents = {
   transition: 'transitionend'
 }
 
-const EventOptions = { passive: true, capture: false }
-
 // Return the browser specific transitionEnd event name
 const getTransitionEndEvent = el => {
   for (const name in TransitionEndEvents) {
@@ -308,7 +299,7 @@ export const BCarousel = /*#__PURE__*/ Vue.extend({
       }
     },
     // Restart auto rotate slides when focus/hover leaves the carousel
-    restart(evt) /* istanbul ignore next: difficult to test */ {
+    restart() /* istanbul ignore next: difficult to test */ {
       if (!this.$el.contains(document.activeElement)) {
         this.start()
       }
@@ -350,15 +341,17 @@ export const BCarousel = /*#__PURE__*/ Vue.extend({
         // Transition End handler
         let called = false
         /* istanbul ignore next: difficult to test */
-        const onceTransEnd = evt => {
+        const onceTransEnd = () => {
           if (called) {
             return
           }
           called = true
           /* istanbul ignore if: transition events cant be tested in JSDOM */
           if (this.transitionEndEvent) {
             const events = this.transitionEndEvent.split(/\s+/)
-            events.forEach(evt => eventOff(currentSlide, evt, onceTransEnd, EventOptions))
+            events.forEach(evt =>
+              eventOff(currentSlide, evt, onceTransEnd, EVENT_OPTIONS_NO_CAPTURE)
+            )
           }
           this._animationTimeout = null
           removeClass(nextSlide, dirClass)
@@ -380,7 +373,9 @@ export const BCarousel = /*#__PURE__*/ Vue.extend({
         /* istanbul ignore if: transition events cant be tested in JSDOM */
         if (this.transitionEndEvent) {
           const events = this.transitionEndEvent.split(/\s+/)
-          events.forEach(event => eventOn(currentSlide, event, onceTransEnd, EventOptions))
+          events.forEach(event =>
+            eventOn(currentSlide, event, onceTransEnd, EVENT_OPTIONS_NO_CAPTURE)
+          )
         }
         // Fallback to setTimeout()
         this._animationTimeout = setTimeout(onceTransEnd, TRANS_DURATION)

diff --git a/src/components/carousel/carousel.spec.js b/src/components/carousel/carousel.spec.js
@@ -32,10 +32,10 @@ const appDef = {
         }
       },
       [
-        h(BCarouselSlide, {}, 'slide 1'),
-        h(BCarouselSlide, {}, 'slide 2'),
-        h(BCarouselSlide, {}, 'slide 3'),
-        h(BCarouselSlide, {}, 'slide 4')
+        h(BCarouselSlide, 'slide 1'),
+        h(BCarouselSlide, 'slide 2'),
+        h(BCarouselSlide, 'slide 3'),
+        h(BCarouselSlide, 'slide 4')
       ]
     )
   }

diff --git a/src/components/carousel/package.json b/src/components/carousel/package.json
@@ -36,7 +36,7 @@
           },
           {
             "prop": "noHoverPause",
-            "description": "When set, disables the pausing of hte slide show when the current slide is hovered"
+            "description": "When set, disables the pausing of the slide show when the current slide is hovered"
           },
           {
             "prop": "interval",

diff --git a/src/components/collapse/collapse.js b/src/components/collapse/collapse.js
@@ -1,19 +1,11 @@
 import Vue from '../../utils/vue'
+import { isBrowser } from '../../utils/env'
+import { addClass, hasClass, removeClass, closest, matches, getCS } from '../../utils/dom'
+import { EVENT_OPTIONS_NO_CAPTURE, eventOnOff } from '../../utils/events'
+import { BVCollapse } from '../../utils/bv-collapse'
 import idMixin from '../../mixins/id'
 import listenOnRootMixin from '../../mixins/listen-on-root'
 import normalizeSlotMixin from '../../mixins/normalize-slot'
-import { isBrowser } from '../../utils/env'
-import { BVCollapse } from '../../utils/bv-collapse'
-import {
-  addClass,
-  hasClass,
-  removeClass,
-  closest,
-  matches,
-  getCS,
-  eventOn,
-  eventOff
-} from '../../utils/dom'
 
 // Events we emit on $root
 const EVENT_STATE = 'bv::collapse::state'
@@ -26,9 +18,6 @@ const EVENT_STATE_SYNC = 'bv::collapse::sync::state'
 const EVENT_TOGGLE = 'bv::toggle::collapse'
 const EVENT_STATE_REQUEST = 'bv::request::collapse::state'
 
-// Event listener options
-const EventOptions = { passive: true, capture: false }
-
 // @vue/component
 export const BCollapse = /*#__PURE__*/ Vue.extend({
   name: 'BCollapse',
@@ -137,28 +126,27 @@ export const BCollapse = /*#__PURE__*/ Vue.extend({
   },
   methods: {
     setWindowEvents(on) {
-      const method = on ? eventOn : eventOff
-      method(window, 'resize', this.handleResize, EventOptions)
-      method(window, 'orientationchange', this.handleResize, EventOptions)
+      eventOnOff(on, window, 'resize', this.handleResize, EVENT_OPTIONS_NO_CAPTURE)
+      eventOnOff(on, window, 'orientationchange', this.handleResize, EVENT_OPTIONS_NO_CAPTURE)
     },
     toggle() {
       this.show = !this.show
     },
-    onEnter(el) {
+    onEnter() {
       this.transitioning = true
       // This should be moved out so we can add cancellable events
       this.$emit('show')
     },
-    onAfterEnter(el) {
+    onAfterEnter() {
       this.transitioning = false
       this.$emit('shown')
     },
-    onLeave(el) {
+    onLeave() {
       this.transitioning = true
       // This should be moved out so we can add cancellable events
       this.$emit('hide')
     },
-    onAfterLeave(el) {
+    onAfterLeave() {
       this.transitioning = false
       this.$emit('hidden')
     },

diff --git a/src/components/collapse/collapse.spec.js b/src/components/collapse/collapse.spec.js
@@ -411,7 +411,7 @@ describe('collapse', () => {
     const localVue = CreateLocalVue()
     const App = localVue.extend({
       render(h) {
-        return h('div', {}, [
+        return h('div', [
           // JSDOM supports getComputedStyle when using stylesheets (non responsive)
           // https://github.com/jsdom/jsdom/blob/master/Changelog.md#030
           h('style', { attrs: { type: 'text/css' } }, '.collapse:not(.show) { display: none; }'),
@@ -471,7 +471,7 @@ describe('collapse', () => {
     const localVue = CreateLocalVue()
     const App = localVue.extend({
       render(h) {
-        return h('div', {}, [
+        return h('div', [
           // JSDOM supports getComputedStyle when using stylesheets (non responsive)
           // Although it appears to be picky about CSS definition ordering
           // https://github.com/jsdom/jsdom/blob/master/Changelog.md#030

diff --git a/src/components/collapse/package.json b/src/components/collapse/package.json
@@ -24,7 +24,7 @@
         "props": [
           {
             "prop": "isNav",
-            "description": "When set, signifies that hte collapse is bart of a navbar, enabling certain features for navbar support"
+            "description": "When set, signifies that the collapse is bart of a navbar, enabling certain features for navbar support"
           },
           {
             "prop": "accordion",

diff --git a/src/components/dropdown/dropdown-item.spec.js b/src/components/dropdown/dropdown-item.spec.js
@@ -96,7 +96,7 @@ describe('dropdown-item', () => {
       const App = localVue.extend({
         router,
         render(h) {
-          return h('ul', {}, [
+          return h('ul', [
             // router-link
             h(BDropdownItem, { props: { to: '/a' } }, ['to-a']),
             // regular link

diff --git a/src/components/dropdown/dropdown.spec.js b/src/components/dropdown/dropdown.spec.js
@@ -433,7 +433,7 @@ describe('dropdown', () => {
     const App = localVue.extend({
       render(h) {
         return h('div', { attrs: { id: 'container' } }, [
-          h(BDropdown, { props: { id: 'test' } }, [h(BDropdownItem, {}, 'item')]),
+          h(BDropdown, { props: { id: 'test' } }, [h(BDropdownItem, 'item')]),
           h('input', { attrs: { id: 'input' } })
         ])
       }
@@ -666,7 +666,7 @@ describe('dropdown', () => {
     const localVue = new CreateLocalVue()
     const App = localVue.extend({
       render(h) {
-        return h('div', {}, [
+        return h('div', [
           h(BDropdown, { props: { id: 'test' } }, [
             h(BDropdownItem, { attrs: { id: 'item-1' } }, 'item'),
             h(BDropdownItem, { attrs: { id: 'item-2' } }, 'item'),

diff --git a/src/components/form-checkbox/form-checkbox.js b/src/components/form-checkbox/form-checkbox.js
@@ -68,13 +68,13 @@ export const BFormCheckbox = /*#__PURE__*/ Vue.extend({
     }
   },
   watch: {
-    computedLocalChecked(newVal, oldVal) {
+    computedLocalChecked(newVal) {
       this.$emit('input', newVal)
       if (this.$refs && this.$refs.input) {
         this.$emit('update:indeterminate', this.$refs.input.indeterminate)
       }
     },
-    indeterminate(newVal, oldVal) {
+    indeterminate(newVal) {
       this.setIndeterminate(newVal)
     }
   },

diff --git a/src/components/form-group/form-group.js b/src/components/form-group/form-group.js
@@ -447,7 +447,7 @@ export const BFormGroup = {
     return h(
       isFieldset ? 'fieldset' : isHorizontal ? BFormRow : 'div',
       data,
-      isHorizontal && isFieldset ? [h(BFormRow, {}, [label, content])] : [label, content]
+      isHorizontal && isFieldset ? [h(BFormRow, [label, content])] : [label, content]
     )
   }
 }