CI/CD: Set Target macOS to 14.0 #20
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @haochengxia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request makes a minor but significant adjustment to the project's build configuration, specifically lowering the target macOS deployment version. This change is crucial for ensuring compatibility with macOS 14.0, which might be necessary for specific development environments or deployment targets.
Highlights
- CI/CD Configuration Update: This pull request modifies the
pyproject.tomlfile to change theCMAKE_OSX_DEPLOYMENT_TARGETfrom15.0to14.0. This means that the project's build system will now target macOS 14.0 as the minimum deployment version.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to lower the target macOS version from 15.0 to 14.0 to improve compatibility. The change correctly updates the scikit-build configuration. However, I've identified a conflicting setting in the cibuildwheel configuration that also needs to be updated to ensure the change is effective for the wheels built in CI.
| @@ -49,7 +49,7 @@ wheel.expand-macos-universal-tags = true | |||
| build-dir = "build" | |||
| cmake.build-type = "Release" | |||
| cmake.args = ["-G", "Ninja"] | |||
| cmake.define = { CMAKE_OSX_DEPLOYMENT_TARGET = "15.0" } | |||
| cmake.define = { CMAKE_OSX_DEPLOYMENT_TARGET = "14.0" } | |||
There was a problem hiding this comment.
While setting CMAKE_OSX_DEPLOYMENT_TARGET here is correct for local builds using scikit-build, there's a conflicting configuration for cibuildwheel in this same file that will likely override this setting during the CI build process.
On line 83, MACOSX_DEPLOYMENT_TARGET is still set to 15.0:
83: environment = { LCS_BUILD_DIR = "{project}/src/libCacheSim/build", MACOSX_DEPLOYMENT_TARGET = "15.0" }The MACOSX_DEPLOYMENT_TARGET environment variable set by cibuildwheel will take precedence, and the wheels produced by the CI will still target macOS 15.0. This would defeat the purpose of this pull request.
To ensure the change is effective for the distributed wheels, please update line 83 to be consistent with this change.
No description provided.