Skip to content

feat: add custom className properties to AvailabilitySettings and CalendarSettingsPlatformWrapper components #22675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add custom className properties to AvailabilitySettings and CalendarSettingsPlatformWrapper components #22675

wants to merge 2 commits into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

feat: add custom className properties to AvailabilitySettings and CalendarSettingsPlatformWrapper components

Summary

This PR adds comprehensive custom className support to two key platform components following the established patterns from recent PRs. The changes provide developers with granular control over styling specific DOM elements within these components.

AvailabilitySettings.tsx changes:

  • Extended CustomClassNames interface with 11 new className properties including save button, mobile menu, sidebar elements, troubleshooter section, and date overrides section
  • Applied new classNames to appropriate DOM elements throughout the component

CalendarSettingsPlatformWrapper.tsx changes:

  • Replaced basic className structure with hierarchical interfaces for destinationCalendarSettingsCustomClassnames and selectedCalendarSettingsCustomClassnames
  • Updated child components (DestinationCalendarSettings, SelectedCalendarsSettings, SelectedCalendarsSettingsPlatformWrapper) to accept and use the new className structures
  • Maintained backward compatibility by supporting both string and object className types

Review & Testing Checklist for Human

  • Test components in running application - Verify all new className properties are applied to the correct DOM elements and styling works as expected
  • Verify backward compatibility - Ensure existing usage of these components continues to work without breaking changes
  • Validate className hierarchy - Check that the hierarchical className structure follows established patterns and makes logical sense for the component structure
  • TypeScript type safety - Confirm no type errors exist across all modified components and prop passing is correct
  • Test responsive behavior - Verify mobile menu and sidebar className applications work correctly across different screen sizes

Recommended test plan:

  1. Import and use both components in a test application with various className combinations
  2. Verify the component tree renders correctly with nested className applications
  3. Test edge cases like undefined/null className props
  4. Check that existing className props (like containerClassName) still work alongside new ones

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    CW["CalendarSettingsPlatformWrapper.tsx<br/>(Interface Updates)"]:::minor-edit
    AS["AvailabilitySettings.tsx<br/>(Major className additions)"]:::major-edit
    DC["DestinationCalendarSettings.tsx<br/>(Updated to use new classNames)"]:::minor-edit
    SC["SelectedCalendarsSettings.tsx<br/>(Updated to use new classNames)"]:::minor-edit
    SCW["SelectedCalendarsSettingsPlatformWrapper.tsx<br/>(Major className applications)"]:::major-edit
    
    CW -->|"passes destinationCalendarSettings<br/>classNames"| DC
    CW -->|"passes selectedCalendarSettings<br/>classNames"| SCW
    SCW -->|"uses className structure"| SC
    
    subgraph Legend
        L1["Major Edit"]:::major-edit
        L2["Minor Edit"]:::minor-edit
        L3["Context/No Edit"]:::context
    end

classDef major-edit fill:#90EE90
classDef minor-edit fill:#87CEEB
classDef context fill:#FFFFFF
Loading

Notes

Link to Devin run: https://app.devin.ai/sessions/7c0f9290e3944d1790cf79c82be5c4ce
Requested by: somay@cal.com

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 22, 2025 •
edited
Loading

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@delve-auditor Delve Auditor
Copy link

delve-auditor bot commented Jul 22, 2025

✅ No security or compliance issues detected. Reviewed everything up to ef98ad3.

Security Overview
  • 🔎 Scanned files: 5 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► AvailabilitySettings.tsx
    Add custom className properties for UI elements
► CalendarSettingsPlatformWrapper.tsx
    Extend className structure with hierarchical properties
► DestinationCalendar.tsx
    Add custom className support
► SelectedCalendarsSettings.tsx
    Add custom className support
► SelectedCalendarsSettingsPlatformWrapper.tsx
    Implement hierarchical className structure

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@SomayChauhan SomayChauhan self-assigned this Jul 28, 2025
@devin-ai-integration
feat: resolve merge conflicts and reapply custom className properties
e4dc154 
- Reset branch to latest main to resolve complex merge conflicts
- Re-added all custom className properties to AvailabilitySettings CustomClassNames interface
- Applied classNames to save button, mobile menu button, sidebar elements, troubleshooter sections
- Updated CalendarSettingsPlatformWrapper with hierarchical className structure
- Enhanced DestinationCalendarSettings and SelectedCalendarsSettings with detailed className support
- All existing functionality preserved while adding new styling capabilities

Co-Authored-By: somay@cal.com <somay@cal.com>
@devin-ai-integration devin-ai-integration bot force-pushed the devin/1753176651-add-custom-classnames-platform-components branch from ef98ad3 to e4dc154 Compare July 28, 2025 15:34
@vercel Vercel
Copy link

vercel bot commented Jul 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jul 28, 2025 4:02pm
cal-eu ⬜️ Ignored (Inspect) Jul 28, 2025 4:02pm

@devin-ai-integration
fix: remove invalid customClassNames prop from DateOverride component
7b3fe2f 
- DateOverride component doesn't accept customClassNames parameter
- Fixes TypeScript error causing CI failure
- Preserves all other custom className functionality

Co-Authored-By: somay@cal.com <somay@cal.com>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

Closing due to inactivity for more than 7 days. Configure here.

@SomayChauhan SomayChauhan reopened this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SomayChauhan SomayChauhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SomayChauhan