Skip to content

fix: fix position of plain support button #22937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Conversation

PeerRich
Copy link
Member

@PeerRich PeerRich commented Aug 6, 2025

CleanShot 2025-08-06 at 18 18 06@2x

@PeerRich PeerRich requested a review from a team as a code owner August 6, 2025 16:18
Copy link
Contributor

coderabbitai bot commented Aug 6, 2025

Walkthrough

The change updates the CSS class names for the container div wrapping the Popover component in the PlainContactForm.tsx file. Specifically, the bottom and right positioning classes are modified from fixed pixel values ("bottom-4" and "right-4") to rem-based values ("bottom-[1rem]" and "right-[1rem]"). No other modifications are made to the component's logic, structure, or exported entities.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/support-position

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app graphite-app bot requested a review from a team August 6, 2025 16:18
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Aug 6, 2025
@graphite-app graphite-app bot requested a review from a team August 6, 2025 16:18
@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Aug 6, 2025
Copy link

graphite-app bot commented Aug 6, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (08/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (08/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (08/06/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
apps/web/lib/plain/PlainContactForm.tsx (1)

161-179: Hard-coded UI strings violate the localization guideline

Multiple visible texts are embedded directly in JSX:

  • Line 161: "Contact support"
  • Lines 174-179: "Message Sent", "Thank you for contacting us…" , "Send Another Message"
  • Line 185: "Describe the issue"
  • Lines 191-193: long placeholder string
  • Line 197: "Attachments (optional)"
  • Line 200: "Add Files"
  • Line 213: button labels such as "Send Message", "Sending"

Per project guideline **/*.tsx: Always use t() for text localization, these should be wrapped in the translation helper, e.g.:

- <p className="mb-5 text-lg font-semibold">Contact support</p>
+ <p className="mb-5 text-lg font-semibold">{t("support.contact")}</p>

Please internationalize all user-facing strings before merging.

Also applies to: 185-204

🧹 Nitpick comments (1)
apps/web/lib/plain/PlainContactForm.tsx (1)

147-147: Arbitrary Tailwind values: double-check build config

bottom-[1rem] / right-[1rem] rely on Tailwind’s arbitrary value syntax, which is only available when JIT mode (default since v3) is correctly wired up, AND when the value is safelisted in case of content-based purging.
If your production build purges class names by scanning files, ensure these two arbitrary classes are discoverable (e.g. not produced dynamically) or add them to the safelist in tailwind.config.js; otherwise the button might disappear in prod.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b410316 and 65f95db.

📒 Files selected for processing (1)
  • apps/web/lib/plain/PlainContactForm.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.tsx

📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)

Always use t() for text localization in frontend code; direct text embedding should trigger a warning

Files:

  • apps/web/lib/plain/PlainContactForm.tsx
**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)

Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js .utc() in hot paths like loops

Files:

  • apps/web/lib/plain/PlainContactForm.tsx

@emrysal emrysal merged commit 737b019 into main Aug 6, 2025
77 of 86 checks passed
@emrysal emrysal deleted the fix/support-position branch August 6, 2025 16:25
emrysal pushed a commit that referenced this pull request Aug 6, 2025
Copy link
Contributor

github-actions bot commented Aug 6, 2025

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants