-
Notifications
You must be signed in to change notification settings - Fork 10.2k
fix: fix position of plain support button #22937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the CSS class names for the container div wrapping the Popover component in the PlainContactForm.tsx file. Specifically, the bottom and right positioning classes are modified from fixed pixel values ("bottom-4" and "right-4") to rem-based values ("bottom-[1rem]" and "right-[1rem]"). No other modifications are made to the component's logic, structure, or exported entities. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (08/06/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (08/06/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (08/06/25)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/web/lib/plain/PlainContactForm.tsx (1)
161-179
: Hard-coded UI strings violate the localization guidelineMultiple visible texts are embedded directly in JSX:
- Line 161:
"Contact support"
- Lines 174-179:
"Message Sent"
,"Thank you for contacting us…"
,"Send Another Message"
- Line 185:
"Describe the issue"
- Lines 191-193: long placeholder string
- Line 197:
"Attachments (optional)"
- Line 200:
"Add Files"
- Line 213: button labels such as
"Send Message"
,"Sending"
Per project guideline
**/*.tsx: Always use t() for text localization
, these should be wrapped in the translation helper, e.g.:- <p className="mb-5 text-lg font-semibold">Contact support</p> + <p className="mb-5 text-lg font-semibold">{t("support.contact")}</p>Please internationalize all user-facing strings before merging.
Also applies to: 185-204
🧹 Nitpick comments (1)
apps/web/lib/plain/PlainContactForm.tsx (1)
147-147
: Arbitrary Tailwind values: double-check build config
bottom-[1rem]
/right-[1rem]
rely on Tailwind’s arbitrary value syntax, which is only available when JIT mode (default since v3) is correctly wired up, AND when the value is safelisted in case of content-based purging.
If your production build purges class names by scanning files, ensure these two arbitrary classes are discoverable (e.g. not produced dynamically) or add them to thesafelist
intailwind.config.js
; otherwise the button might disappear in prod.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/lib/plain/PlainContactForm.tsx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.tsx
📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)
Always use
t()
for text localization in frontend code; direct text embedding should trigger a warning
Files:
apps/web/lib/plain/PlainContactForm.tsx
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)
Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js
.utc()
in hot paths like loops
Files:
apps/web/lib/plain/PlainContactForm.tsx
E2E results are ready! |
Uh oh!
There was an error while loading. Please reload this page.