-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix bug#102, typor#103 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changkun
reviewed
Jun 2, 2020
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
All the suggestions should bave been adapted at the last commit. |
Sorry, but you have one more left |
changkun
reviewed
Jun 2, 2020
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Well, it should be ok now. |
changkun
reviewed
Jun 2, 2020
Co-authored-by: Ou Changkun <hi@changkun.us>
GitHub clone was too slow, work with webpage always make some troublesome . . . this time should be ok?? |
changkun
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #102
resolve #103
Description
fixed bug#102
Change List
Fix bug#102 of string literal is a rvalue just in class context
Resolve error content of book/en-US/03-runtime.md
说明
解决 bug#102, typor#103
变化箱单