Skip to content

Fix bug#102, typor#103 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 3, 2020
Merged

Fix bug#102, typor#103 #105

merged 17 commits into from
Jun 3, 2020

Conversation

cathaysia
Copy link
Contributor

@cathaysia cathaysia commented Jun 1, 2020

resolve #102
resolve #103

Description

fixed bug#102

Change List

  • Fix bug#102 of string literal is a rvalue just in class context

  • Resolve error content of book/en-US/03-runtime.md


说明

解决 bug#102, typor#103

变化箱单

  • 修复了关于字符串仅在类中为右值的说明

cathaysia and others added 7 commits June 2, 2020 15:03
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
@cathaysia
Copy link
Contributor Author

All the suggestions should bave been adapted at the last commit.

@changkun
Copy link
Owner

changkun commented Jun 2, 2020

Sorry, but you have one more left

cathaysia and others added 6 commits June 2, 2020 16:12
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
Co-authored-by: Ou Changkun <hi@changkun.us>
@cathaysia
Copy link
Contributor Author

Well, it should be ok now.

Co-authored-by: Ou Changkun <hi@changkun.us>
@cathaysia
Copy link
Contributor Author

GitHub clone was too slow, work with webpage always make some troublesome . . . this time should be ok??

Copy link
Owner

@changkun changkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changkun
Copy link
Owner

changkun commented Jun 3, 2020

Thanks!

@changkun changkun merged commit 3abc907 into changkun:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

笔误:3.3节:“需要拿到一个将亡值,就需要用到右值引用的申明:” 3.3 中 原始字面量不一定是右值
2 participants