Skip to content

Remove max_size parameter #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2021
Merged

Remove max_size parameter #6

merged 1 commit into from
Jul 5, 2021

Conversation

lesamouraipourpre
Copy link
Contributor

Remove the max_size parameter. It is no longer used by displayio.Group
Ref: adafruit/circuitpython#4959

Tested on a Pynt:

Adafruit CircuitPython 6.3.0 on 2021-06-01; Adafruit PyPortal with samd51j20

@lesamouraipourpre lesamouraipourpre mentioned this pull request Jul 4, 2021
Closed
41 tasks
jposada202020
jposada202020 reviewed Jul 5, 2021
View reviewed changes
Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was tested on

Adafruit CircuitPython 6.3.0 on 2021-06-01; Adafruit PyPortal Titano with samd51j20

using both simple and multiple examples

LGTM

@jposada202020 jposada202020 merged commit 221e843 into circuitpython:main Jul 5, 2021
@lesamouraipourpre lesamouraipourpre deleted the max-size branch July 13, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jposada202020 jposada202020 jposada202020 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesamouraipourpre @jposada202020