-
Notifications
You must be signed in to change notification settings - Fork 58
Remove support for v0.2 v0.1 events #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's not required and these versions are seldomly used since 1.0 came out. |
I don't see why we need to intentionally create breaking changes for end users. I think I'd prefer saying the new "pythonic" API only supports v1 and v0.3 and that eventually when we deprecate the old API, we'll remove it entirely, including support for these versions. |
Seems reasonable. I'm going to remove my existing PR and instead change sample code and README to using v1/v03 classes |
@di 0.1, 0.2 events are strictly not required to be supported according to the spec. This is common amongst other SDKs. Previous publications can be used by existing users if they need this support. It should be OK to remove these event versions like we've done so for other language SDKs. |
OK, looks like this happened anyways. Please update CHANGELOG.md to indicate to users that this is removed in the future version. This wasn't done in #43, I didn't have an opportunity to review that PR. |
Yes, I merged the PR as it aligns with other language SDKs and the spec. Looking for a review on #36 before continuing. |
The SDK spec states we don't have to support v0.2 v0.1 versions. We should remove support and document current support here.
The text was updated successfully, but these errors were encountered: